Repository navigation
[Snyk] Upgrade fast-glob from 3.2.7 to 3.3.2 - #2
Merged
Merged
Conversation
Snyk has created this PR to upgrade fast-glob from 3.2.7 to 3.3.2. See this package in npm: fast-glob See this project in Snyk: https://app.snyk.io/org/sherfeyinv/project/605bca3a-582e-4705-9bb6-f64d8166f56f?utm_source=github&utm_medium=referral&page=upgrade-pr
SherfeyInv
pushed a commit
that referenced
this pull request
May 7, 2026
…on serialization fails (nrwl#33274) ## Current Behavior We have tried to enable v8 serialization again... but it still seems problematic. We don't want to revert again... so we evaluated some options: 1. Disable by default 2. Disable for the single client method we think may be problematic 3. Fall back to JSON if v8 fails 4. Disable by default and still fall back if JSON fails ## Expected Behavior We decided to update Nx such that the default behavior will be a combination of #4, and #2. So by default we use JSON, if that serialization fails we'll try v8... but there's an exception so the method we know to be an issue will never try v8. If you opt in to v8 by default, the combo changes to #3 + #2. So, by default we'd use v8... if it fails try json... never try v8 for processInBackground ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
SherfeyInv
pushed a commit
that referenced
this pull request
May 7, 2026
nrwl#34640) Bun includes extra consecutive async frames for async functions in call stacks, causing `preventRecursionInGraphConstruction` to falsely detect a recursive loop during normal project graph construction. ## Root Cause `preventRecursionInGraphConstruction` uses `getCallSites().slice(2)` to skip the top 2 frames (itself + `buildProjectGraphAndSourceMapsWithoutDaemon`), then checks if `buildProjectGraphAndSourceMapsWithoutDaemon` appears again in the remaining frames. In Bun, `buildProjectGraphAndSourceMapsWithoutDaemon` appears **twice consecutively** due to async frame duplication — leaving one occurrence after the slice, which incorrectly triggers the loop error. **Node call stack (after `slice(2)`):** ``` #0 createProjectGraphAndSourceMapsAsync ← clean #1 createProjectGraphAsync #2 runOne ``` **Bun call stack (after `slice(2)`):** ``` #0 buildProjectGraphAndSourceMapsWithoutDaemon ← false positive! #1 createProjectGraphAndSourceMapsAsync #2 createProjectGraphAndSourceMapsAsync ← Bun duplicates async frames #3 createProjectGraphAsync ``` ## Fix Since the call stack recursion check does not work reliably under Bun, `preventRecursionInGraphConstruction` now returns early when running under Bun, detected via `'Bun' in globalThis` — consistent with the existing Bun runtime detection pattern used elsewhere in the codebase (e.g., `isolated-plugin.ts`). The original `slice(2)` logic is preserved unchanged for Node.js and other runtimes. ```ts export function preventRecursionInGraphConstruction() { // Bun's async stack traces include extra frames that cause false positives in the // recursion check below, so we skip the check when running under Bun. if ('Bun' in globalThis) { return; } // ... existing Node.js check ... } ``` <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> ---- *This section details on the original issue you should resolve* <issue_title>getCallSites output differs between Node and Bun triggering loop detection</issue_title> <issue_description>### Current Behavior Hey team, I am trying to use Bun (1.3.5) instead of Node (v22.17.0) for running Nx (v22.1.3) and bumped into the following error: Command: ```bash bunx --bun nx run api:build ``` Error: ``` NX Project graph construction cannot be performed due to a loop detected in the call stack. This can happen if 'createProjectGraphAsync' is called directly or indirectly during project graph construction. To avoid this, you can add a check against "global.NX_GRAPH_CREATION" before calling "createProjectGraphAsync". Call stack: buildProjectGraphAndSourceMapsWithoutDaemon (/app/node_modules/.pnpm/nx@22.1.3_@swc-node+register@1.10.9_@swc+core@1.11.1_@swc+helpers@0.5.15__@swc+types@0.1.18_t_twtgkxomntuzxcyp4ewkmtxn2q/node_modules/nx/src/project-graph/project-graph.js:81:62) createProjectGraphAndSourceMapsAsync (/app/node_modules/.pnpm/nx@22.1.3_@swc-node+register@1.10.9_@swc+core@1.11.1_@swc+helpers@0.5.15__@swc+types@0.1.18_t_twtgkxomntuzxcyp4ewkmtxn2q/node_modules/nx/src/project-graph/project-graph.js:274:31) createProjectGraphAndSourceMapsAsync (/app/node_modules/.pnpm/nx@22.1.3_@swc-node+register@1.10.9_@swc+core@1.11.1_@swc+helpers@0.5.15__@swc+types@0.1.18_t_twtgkxomntuzxcyp4ewkmtxn2q/node_modules/nx/src/project-graph/project-graph.js:225:53) createProjectGraphAsync (/app/node_modules/.pnpm/nx@22.1.3_@swc-node+register@1.10.9_@swc+core@1.11.1_@swc+helpers@0.5.15__@swc+types@0.1.18_t_twtgkxomntuzxcyp4ewkmtxn2q/node_modules/nx/src/project-graph/project-graph.js:222:45) createProjectGraphAsync (/app/node_modules/.pnpm/nx@22.1.3_@swc-node+register@1.10.9_@swc+core@1.11.1_@swc+helpers@0.5.15__@swc+types@0.1.18_t_twtgkxomntuzxcyp4ewkmtxn2q/node_modules/nx/src/project-graph/project-graph.js:205:40) runOne (/app/node_modules/.pnpm/nx@22.1.3_@swc-node+register@1.10.9_@swc+core@1.11.1_@swc+helpers@0.5.15__@swc+types@0.1.18_t_twtgkxomntuzxcyp4ewkmtxn2q/node_modules/nx/src/command-line/run/run-one.js:23:52) runOne (/app/node_modules/.pnpm/nx@22.1.3_@swc-node+register@1.10.9_@swc+core@1.11.1_@swc+helpers@0.5.15__@swc+types@0.1.18_t_twtgkxomntuzxcyp4ewkmtxn2q/node_modules/nx/src/command-line/run/run-one.js:16:23) Pass --verbose to see the stacktrace. ``` After some digging I found that the stack trace produced by https://github.com/nrwl/nx/blob/691bb320ce1e9cc2872e1a1b364d3fdeb9e1ad0e/packages/nx/src/utils/call-sites.ts differs between Node and Bun. When https://github.com/nrwl/nx/blob/691bb320ce1e9cc2872e1a1b364d3fdeb9e1ad0e/packages/nx/src/project-graph/project-graph.ts#L422 is run, the produced function call tracing is: Node (v22.17.0): ``` nrwl/nx#0 createProjectGraphAndSourceMapsAsync nrwl#1 createProjectGraphAsync nrwl#2 runOne nrwl#3 <anonymous> nrwl#4 <anonymous> nrwl#5 handleErrors nrwl#6 handler ``` Bun (1.3.5): ``` nrwl/nx#0 buildProjectGraphAndSourceMapsWithoutDaemon <- This entry causes Nx to detect a loop nrwl#1 createProjectGraphAndSourceMapsAsync nrwl#2 createProjectGraphAndSourceMapsAsync nrwl#3 createProjectGraphAsync nrwl#4 createProjectGraphAsync nrwl#5 runOne nrwl#6 runOne ``` This is not a Nx bug per-se, but wondering if this falls into the efforts of supporting Bun into Nx (i.e. https://nx.dev/blog/nx-19-5-adds-stackblitz-new-features-and-more#bun-and-pnpm-v9-support)? I will cross post the above into the Bun repo too for input. ### Expected Behavior Able to execute Nx commands with Bun ### GitHub Repo _No response_ ### Steps to Reproduce 1. Run bunx --bun nx run api:build ### Nx Report ```shell NX_DAEMON=true bunx --bun nx --disableNxCache --disableRemoteCache --outputStyle dynamic-legacy report 1 ✘ 16:18:00 NX Report complete - copy this into the issue template Node : 24.3.0 OS : darwin-arm64 Native Target : aarch64-macos pnpm : 9.6.0 nx : 22.1.3 @nx/js : 22.1.3 @nx/jest : 22.1.3 @nx/eslint : 22.1.3 @nx/workspace : 22.1.3 @nx/cypress : 22.1.3 @nx/devkit : 22.1.3 @nx/esbuild : 22.1.3 @nx/eslint-plugin : 22.1.3 @nx/module-federation : 22.1.3 @nx/nest : 22.1.3 @nx/next : 22.1.3 @nx/node : 22.1.3 @nx/playwright : 22.1.3 @nx/plugin : 22.1.3 @nx/react : 22.1.3 @nx/rollup : 22.1.3 @nx/storybook : 22.1.3 @nx/vite : 22.1.3 @nx/vitest : 22.1.3 @nx/web : 22.1.3 @nx/webpack : 22.1.3 @nx/docker : 22.1.3 nx-cloud : 19.1.0 @nrwl/nx-cloud : 19.1.0 typescript : 5.7.3 --------------------------------------- Registered Plugins: @nxlv/python --------------------------------------- Community plu... </details> <!-- START COPILOT CODING AGENT SUFFIX --> - Fixes nrwl#33997 <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/nrwl/nx/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AgentEnder <6933928+AgentEnder@users.noreply.github.com> Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com> Co-authored-by: Copilot <Copilot@users.noreply.github.com>
SherfeyInv
pushed a commit
that referenced
this pull request
May 7, 2026
## Current Behavior Searching for `nx.json` on nx.dev/docs does not surface the actual nx.json reference page in the top results. The `.NET Plugin for Nx` and other technology introduction pages rank higher because they have `weight: 5` in frontmatter, which inflates their body text scoring via Pagefind's `data-pagefind-weight` attribute (~25x impact via quadratic scaling). The same issue affects `project.json`, `inputs`, and other reference pages. ## Expected Behavior Reference pages whose title exactly matches the search query should rank first or near the top. Technology introduction pages should still be discoverable for their framework name but should not outrank reference pages for terms they merely mention in body text. **After this change:** - `nx.json` → "nx.json Reference" is `#1` (was `#7+`) - `project.json` → "Project Configuration" is `#1` - `angular` → "Angular Plugin for Nx" is `#1` (preserved) - `nest` → "Nest.js Plugin for Nx" is `#1` (preserved) - `react` → "React Plugin for Nx" is `#2` (React Native `#1` — valid match) **Changes:** - Reduce `weight` on 35 technology introduction pages from `5` → `2` to reduce body text inflation while keeping a modest boost - Reduce `weight` on adding-to-monorepo guide from `6.4` → `2` - Adjust Pagefind ranking params: `termFrequency: 0.75 → 0.65`, `pageLength: 0.5 → 0.3` to reduce the penalty on long reference pages ## Related Issue(s) Fixes DOC-475 Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
SherfeyInv
pushed a commit
that referenced
this pull request
Aug 17, 2026
…rwl#34927) ## Description Fixes an infinite restart loop in `nx serve` that occurs when using the `@nx/webpack:webpack` executor with a standard `webpack.config.js` (non-composable path). The root cause is that the `watch` option from the executor is not propagated to the webpack configuration object when the `withNx()` helper is bypassed. Because `config.watch` remains undefined, `runWebpack()` defaults to a single-run build and completes the observable immediately. The `@nx/js:node` executor interprets this completion as a signal to restart the process, creating a loop every ~2 seconds regardless of file changes. This was previously "accidentally" working for users of the composable path (`withNx`) because that utility handles the flag internally. This fix ensures the standard plugin path is also respected. ## Current Behavior Using a plain `webpack.config.js` with the `NxAppWebpackPlugin` results in `watch` being set to `undefined` in the final config. ```javascript // webpack.config.js const { NxAppWebpackPlugin } = require('@nx/webpack/app-plugin'); module.exports = { plugins: [new NxAppWebpackPlugin({ target: 'node', ... })], }; ``` Running `nx serve` triggers a build, the observable completes, and the Node process restarts indefinitely. ## Expected Behavior The `options.watch` flag from the executor should be forwarded to the final webpack config. This ensures the build observable remains open between rebuilds, preventing unnecessary process restarts. ## How to Verify 1. Create a Node/NestJS application using a standard `webpack.config.js` (not using `composePlugins`). 2. Run `nx serve <app-name>`. 3. Verify the application stays alive after the initial build and only restarts when a file change is detected. ## Results ### BEFORE fix — 25 seconds of output: ``` [Nest] 91794 - started 08:45:13 [Nest] 91807 - started 08:45:13 ← restart #1, <1 second later [Nest] 91820 - started 08:45:14 ← restart #2 [Nest] 91833 - started 08:45:14 ← restart #3 [Nest] 91846 - started 08:45:15 ← restart #4 ... 20+ restarts, every ~1 second, with no file changes ``` ### After fix ``` [Nest] 92962 - started 08:45:53 ← stays alive for the entire duration ← one PID, no restarts ← exited cleanly on timeout ``` ## Related Issue(s) Fixes nrwl#22945 Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was automatically created by Snyk using the credentials of a real user.

Snyk has created this PR to upgrade fast-glob from 3.2.7 to 3.3.2.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 8 versions ahead of your current version.
The recommended version was released on 7 months ago.
Release notes
Package name: fast-glob
-
3.3.2 - 2023-11-06
- Handle square brackets as a special character on Windows in escape functions (#425)
- Keep escaping after brace expansion (#422)
-
3.3.1 - 2023-07-22
-
3.3.0 - 2023-06-30
- In the past, we mishandled patterns that contained slashes when the
- Several problems with matching patterns that contain brace expansion have been resolved. The primary issue solved is when the pattern has duplicate slashes after it is expanded (#394), or the
- All negative patterns will now have the
- The issue that led to duplicates in the results when overlapping or duplicate patterns were present among the patterns has been fixed. At the moment, we are only talking about leading dot. Other cases are not included. For example, running with the patterns
- The benchmark in CI is now running on Node.js 20.
- The benchmark now uses the public package bencho instead of an in-house implementation. You may want to try this solution for your packages and provide feedback.
- @ josh-hemphill made their first contribution in #383
- @ mairaw made their first contribution in #401
-
3.2.12 - 2022-09-09
===> Benchmark pattern "*" with 100 launches (regression, async)
-
3.2.10 - 2022-01-09
- Fixed a regression in
- @ amitdahan made their first contribution in #348
-
3.2.9 - 2022-01-07
- Fixed a regression in
-
3.2.8 - 2022-01-07
- Some documentation improvements (#327, thanks @ MarcelloTheArcane).
- The CodeQL action has been added to CI pipeline (#338, thanks @ XhmikosR).
- @ MarcelloTheArcane made their first contribution in #327
- @ Trott made their first contribution in #336
- @ XhmikosR made their first contribution in #338
-
3.2.7 - 2021-07-08
from fast-glob GitHub release notes🐛 Bug fixes
This release fixes a regression for cases where the
ignoreoption is used with a string (#403, #404).The public interface of this package does not support a string as the value for the
ignoreoption since 2018 year (release).So, in the next major release, we will reintroduce method implementations that do not involve strings in the
ignoreoption.🚀 Improvements
Method aliases
New methods (
glob,globSync,globStream) have been added in addition to the current methods (default import,sync,stream), which eliminate the need to rename the method when importing. In addition, anasyncalias has been added for the default import, which makes it possible to use this packet with ESM.Method to convert paths to globs
A new method (
convertPathToPattern) has been added in this release to convert a path to a pattern. The primary goal is to enable users to avoid processing Windows paths in each location where this package is used by utilities from third-party packages.See more details in the pull request.
🐛 Bug fixes
baseNameMatchoption was enabled, which went against the documented behavior. (#312)micromatchpackage does not correctly generate a regular expression (#365).dotoption enabled when matching paths. Previously, the!**/*patterns did not exclude hidden files (start with a dot). (#343)['./file.md', 'file.md', '*']will now only includefile.mdonce in the results. (#190)📖 Documentation
A clarifying note has been added for the
concurrencyoption, which provides more detailed information about the Thread Pool utilization.⚙️ Infrastructure
🥇 New Contributors
🐛 Bug fixes
Fixed an issue introduced in
3.2.7related to incorrect application of patterns to entries with a trailing slash when the entry is not a directory.Before changes:
After fix:
Thanks @ AgentEnder for the issue (#357).
🚀 Improvements
This release includes performance improvements for the asynchronous method. For this method we now use an asynchronous directory traversal interface instead of using a streaming interface. This gives up to 15% acceleration for medium and large directories. The result depends a lot on hardware.
You can find the benchmark results for this release in CI here.
Here are a few of measurements on my laptop:
===> Max stdev: 7 | Retries: 3 | Options: {}
Name Time, ms Time stdev, % Memory, MB Memory stdev, % Entries Errors Retries
--------------------- -------- ------------- ---------- --------------- ------- ------ -------
fast-glob-current.js 4.390 0.252 6.253 0.015 4 0 1
fast-glob-previous.js 5.653 0.633 6.051 0.056 4 0 1
===> Benchmark pattern "**" with 100 launches (regression, async)
===> Max stdev: 7 | Retries: 3 | Options: {}
Name Time, ms Time stdev, % Memory, MB Memory stdev, % Entries Errors Retries
--------------------- -------- ------------- ---------- --------------- ------- ------ -------
fast-glob-current.js 34.587 1.287 10.654 0.607 11835 0 1
fast-glob-previous.js 41.972 2.086 10.236 1.224 11835 0 1
3.2.11 - 2022-01-14
🐛 Bug fixes
Yeap, this is another release aimed at fixing problems with detecting brace expansions in patterns. This time, patterns like
abc/{a.txt,b.js}was not marked as a dynamic pattern. So, now the regex has been rewritten to a generalized solution as a function to avoid future problems due to the complexity of the regular expression.Thanks @ MurzNN for the report of this problem (#351).
🐛 Bug fixes
3.2.8when the{a,b,c}pattern no longer considered a dynamic pattern (thanks @ amitdahan, #347).🥇 New Contributors
🐛 Bug fixes
3.2.8with invalid regular expression on older node.js versions (#345).🐛 Bug fixes
Fix directory matching with trailing slashes (#290)
Previously the
src/*/pattern did not work as expected (likesrc/*).Double-slash in the middle of the pattern is not collapsed (#330)
Starting from this release, patterns like
src//*will work like similar patterns without duplicate slashes. This was done for continuity with other solutions (glob,ls src//*, python, golang, …).Adjust inefficient regular expressions (#336, #342, #344)
📖 Documentation
⚙️ Infrastructure
🥇 New Contributors
🐛 Bug fixes
The previous release (
3.2.6) introduced a regression, which makes negative patterns were not applied to patterns outside the current directory.This release fixes the issue.
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: