Repository navigation
[Snyk] Upgrade source-map-support from 0.5.19 to 0.5.21 - #3
Merged
Merged
Conversation
Snyk has created this PR to upgrade source-map-support from 0.5.19 to 0.5.21. See this package in npm: source-map-support See this project in Snyk: https://app.snyk.io/org/sherfeyinv/project/605bca3a-582e-4705-9bb6-f64d8166f56f?utm_source=github&utm_medium=referral&page=upgrade-pr
SherfeyInv
pushed a commit
that referenced
this pull request
Aug 16, 2025
* feat: add angular-rspack package * feat: add angular-rspack-compiler package * feat: add angular-rsbuild package * docs: readme updates
SherfeyInv
pushed a commit
that referenced
this pull request
Aug 16, 2025
* feat: add angular-rspack package * feat: add angular-rspack-compiler package * feat: add angular-rsbuild package * docs: readme updates
SherfeyInv
pushed a commit
that referenced
this pull request
May 7, 2026
…on serialization fails (nrwl#33274) ## Current Behavior We have tried to enable v8 serialization again... but it still seems problematic. We don't want to revert again... so we evaluated some options: 1. Disable by default 2. Disable for the single client method we think may be problematic 3. Fall back to JSON if v8 fails 4. Disable by default and still fall back if JSON fails ## Expected Behavior We decided to update Nx such that the default behavior will be a combination of #4, and #2. So by default we use JSON, if that serialization fails we'll try v8... but there's an exception so the method we know to be an issue will never try v8. If you opt in to v8 by default, the combo changes to #3 + #2. So, by default we'd use v8... if it fails try json... never try v8 for processInBackground ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
SherfeyInv
pushed a commit
that referenced
this pull request
May 7, 2026
nrwl#34640) Bun includes extra consecutive async frames for async functions in call stacks, causing `preventRecursionInGraphConstruction` to falsely detect a recursive loop during normal project graph construction. ## Root Cause `preventRecursionInGraphConstruction` uses `getCallSites().slice(2)` to skip the top 2 frames (itself + `buildProjectGraphAndSourceMapsWithoutDaemon`), then checks if `buildProjectGraphAndSourceMapsWithoutDaemon` appears again in the remaining frames. In Bun, `buildProjectGraphAndSourceMapsWithoutDaemon` appears **twice consecutively** due to async frame duplication — leaving one occurrence after the slice, which incorrectly triggers the loop error. **Node call stack (after `slice(2)`):** ``` #0 createProjectGraphAndSourceMapsAsync ← clean #1 createProjectGraphAsync #2 runOne ``` **Bun call stack (after `slice(2)`):** ``` #0 buildProjectGraphAndSourceMapsWithoutDaemon ← false positive! #1 createProjectGraphAndSourceMapsAsync #2 createProjectGraphAndSourceMapsAsync ← Bun duplicates async frames #3 createProjectGraphAsync ``` ## Fix Since the call stack recursion check does not work reliably under Bun, `preventRecursionInGraphConstruction` now returns early when running under Bun, detected via `'Bun' in globalThis` — consistent with the existing Bun runtime detection pattern used elsewhere in the codebase (e.g., `isolated-plugin.ts`). The original `slice(2)` logic is preserved unchanged for Node.js and other runtimes. ```ts export function preventRecursionInGraphConstruction() { // Bun's async stack traces include extra frames that cause false positives in the // recursion check below, so we skip the check when running under Bun. if ('Bun' in globalThis) { return; } // ... existing Node.js check ... } ``` <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> ---- *This section details on the original issue you should resolve* <issue_title>getCallSites output differs between Node and Bun triggering loop detection</issue_title> <issue_description>### Current Behavior Hey team, I am trying to use Bun (1.3.5) instead of Node (v22.17.0) for running Nx (v22.1.3) and bumped into the following error: Command: ```bash bunx --bun nx run api:build ``` Error: ``` NX Project graph construction cannot be performed due to a loop detected in the call stack. This can happen if 'createProjectGraphAsync' is called directly or indirectly during project graph construction. To avoid this, you can add a check against "global.NX_GRAPH_CREATION" before calling "createProjectGraphAsync". Call stack: buildProjectGraphAndSourceMapsWithoutDaemon (/app/node_modules/.pnpm/nx@22.1.3_@swc-node+register@1.10.9_@swc+core@1.11.1_@swc+helpers@0.5.15__@swc+types@0.1.18_t_twtgkxomntuzxcyp4ewkmtxn2q/node_modules/nx/src/project-graph/project-graph.js:81:62) createProjectGraphAndSourceMapsAsync (/app/node_modules/.pnpm/nx@22.1.3_@swc-node+register@1.10.9_@swc+core@1.11.1_@swc+helpers@0.5.15__@swc+types@0.1.18_t_twtgkxomntuzxcyp4ewkmtxn2q/node_modules/nx/src/project-graph/project-graph.js:274:31) createProjectGraphAndSourceMapsAsync (/app/node_modules/.pnpm/nx@22.1.3_@swc-node+register@1.10.9_@swc+core@1.11.1_@swc+helpers@0.5.15__@swc+types@0.1.18_t_twtgkxomntuzxcyp4ewkmtxn2q/node_modules/nx/src/project-graph/project-graph.js:225:53) createProjectGraphAsync (/app/node_modules/.pnpm/nx@22.1.3_@swc-node+register@1.10.9_@swc+core@1.11.1_@swc+helpers@0.5.15__@swc+types@0.1.18_t_twtgkxomntuzxcyp4ewkmtxn2q/node_modules/nx/src/project-graph/project-graph.js:222:45) createProjectGraphAsync (/app/node_modules/.pnpm/nx@22.1.3_@swc-node+register@1.10.9_@swc+core@1.11.1_@swc+helpers@0.5.15__@swc+types@0.1.18_t_twtgkxomntuzxcyp4ewkmtxn2q/node_modules/nx/src/project-graph/project-graph.js:205:40) runOne (/app/node_modules/.pnpm/nx@22.1.3_@swc-node+register@1.10.9_@swc+core@1.11.1_@swc+helpers@0.5.15__@swc+types@0.1.18_t_twtgkxomntuzxcyp4ewkmtxn2q/node_modules/nx/src/command-line/run/run-one.js:23:52) runOne (/app/node_modules/.pnpm/nx@22.1.3_@swc-node+register@1.10.9_@swc+core@1.11.1_@swc+helpers@0.5.15__@swc+types@0.1.18_t_twtgkxomntuzxcyp4ewkmtxn2q/node_modules/nx/src/command-line/run/run-one.js:16:23) Pass --verbose to see the stacktrace. ``` After some digging I found that the stack trace produced by https://github.com/nrwl/nx/blob/691bb320ce1e9cc2872e1a1b364d3fdeb9e1ad0e/packages/nx/src/utils/call-sites.ts differs between Node and Bun. When https://github.com/nrwl/nx/blob/691bb320ce1e9cc2872e1a1b364d3fdeb9e1ad0e/packages/nx/src/project-graph/project-graph.ts#L422 is run, the produced function call tracing is: Node (v22.17.0): ``` nrwl/nx#0 createProjectGraphAndSourceMapsAsync nrwl#1 createProjectGraphAsync nrwl#2 runOne nrwl#3 <anonymous> nrwl#4 <anonymous> nrwl#5 handleErrors nrwl#6 handler ``` Bun (1.3.5): ``` nrwl/nx#0 buildProjectGraphAndSourceMapsWithoutDaemon <- This entry causes Nx to detect a loop nrwl#1 createProjectGraphAndSourceMapsAsync nrwl#2 createProjectGraphAndSourceMapsAsync nrwl#3 createProjectGraphAsync nrwl#4 createProjectGraphAsync nrwl#5 runOne nrwl#6 runOne ``` This is not a Nx bug per-se, but wondering if this falls into the efforts of supporting Bun into Nx (i.e. https://nx.dev/blog/nx-19-5-adds-stackblitz-new-features-and-more#bun-and-pnpm-v9-support)? I will cross post the above into the Bun repo too for input. ### Expected Behavior Able to execute Nx commands with Bun ### GitHub Repo _No response_ ### Steps to Reproduce 1. Run bunx --bun nx run api:build ### Nx Report ```shell NX_DAEMON=true bunx --bun nx --disableNxCache --disableRemoteCache --outputStyle dynamic-legacy report 1 ✘ 16:18:00 NX Report complete - copy this into the issue template Node : 24.3.0 OS : darwin-arm64 Native Target : aarch64-macos pnpm : 9.6.0 nx : 22.1.3 @nx/js : 22.1.3 @nx/jest : 22.1.3 @nx/eslint : 22.1.3 @nx/workspace : 22.1.3 @nx/cypress : 22.1.3 @nx/devkit : 22.1.3 @nx/esbuild : 22.1.3 @nx/eslint-plugin : 22.1.3 @nx/module-federation : 22.1.3 @nx/nest : 22.1.3 @nx/next : 22.1.3 @nx/node : 22.1.3 @nx/playwright : 22.1.3 @nx/plugin : 22.1.3 @nx/react : 22.1.3 @nx/rollup : 22.1.3 @nx/storybook : 22.1.3 @nx/vite : 22.1.3 @nx/vitest : 22.1.3 @nx/web : 22.1.3 @nx/webpack : 22.1.3 @nx/docker : 22.1.3 nx-cloud : 19.1.0 @nrwl/nx-cloud : 19.1.0 typescript : 5.7.3 --------------------------------------- Registered Plugins: @nxlv/python --------------------------------------- Community plu... </details> <!-- START COPILOT CODING AGENT SUFFIX --> - Fixes nrwl#33997 <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/nrwl/nx/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AgentEnder <6933928+AgentEnder@users.noreply.github.com> Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com> Co-authored-by: Copilot <Copilot@users.noreply.github.com>
SherfeyInv
pushed a commit
that referenced
this pull request
Aug 17, 2026
…rwl#34927) ## Description Fixes an infinite restart loop in `nx serve` that occurs when using the `@nx/webpack:webpack` executor with a standard `webpack.config.js` (non-composable path). The root cause is that the `watch` option from the executor is not propagated to the webpack configuration object when the `withNx()` helper is bypassed. Because `config.watch` remains undefined, `runWebpack()` defaults to a single-run build and completes the observable immediately. The `@nx/js:node` executor interprets this completion as a signal to restart the process, creating a loop every ~2 seconds regardless of file changes. This was previously "accidentally" working for users of the composable path (`withNx`) because that utility handles the flag internally. This fix ensures the standard plugin path is also respected. ## Current Behavior Using a plain `webpack.config.js` with the `NxAppWebpackPlugin` results in `watch` being set to `undefined` in the final config. ```javascript // webpack.config.js const { NxAppWebpackPlugin } = require('@nx/webpack/app-plugin'); module.exports = { plugins: [new NxAppWebpackPlugin({ target: 'node', ... })], }; ``` Running `nx serve` triggers a build, the observable completes, and the Node process restarts indefinitely. ## Expected Behavior The `options.watch` flag from the executor should be forwarded to the final webpack config. This ensures the build observable remains open between rebuilds, preventing unnecessary process restarts. ## How to Verify 1. Create a Node/NestJS application using a standard `webpack.config.js` (not using `composePlugins`). 2. Run `nx serve <app-name>`. 3. Verify the application stays alive after the initial build and only restarts when a file change is detected. ## Results ### BEFORE fix — 25 seconds of output: ``` [Nest] 91794 - started 08:45:13 [Nest] 91807 - started 08:45:13 ← restart #1, <1 second later [Nest] 91820 - started 08:45:14 ← restart #2 [Nest] 91833 - started 08:45:14 ← restart #3 [Nest] 91846 - started 08:45:15 ← restart #4 ... 20+ restarts, every ~1 second, with no file changes ``` ### After fix ``` [Nest] 92962 - started 08:45:53 ← stays alive for the entire duration ← one PID, no restarts ← exited cleanly on timeout ``` ## Related Issue(s) Fixes nrwl#22945 Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was automatically created by Snyk using the credentials of a real user.

Snyk has created this PR to upgrade source-map-support from 0.5.19 to 0.5.21.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 2 versions ahead of your current version.
The recommended version was released on 3 years ago.
Release notes
Package name: source-map-support
-
0.5.21 - 2021-11-19
-
0.5.20 - 2021-09-09
-
0.5.19 - 2020-04-24
from source-map-support GitHub release notes0.5.21
0.5.20
0.5.19
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: