Skip to content

[Snyk] Upgrade ora from 5.3.0 to 5.4.1 - #4

Merged
SherfeyInv merged 2 commits into
masterfrom
snyk-upgrade-fcc49cd8969831c78d6bccb6957f4814
Jun 30, 2024
Merged

SherfeyInv merged 2 commits into
masterfrom
snyk-upgrade-fcc49cd8969831c78d6bccb6957f4814

Conversation

@SherfeyInv

Copy link
Copy Markdown
Owner

This PR was automatically created by Snyk using the credentials of a real user.


![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)

Snyk has created this PR to upgrade ora from 5.3.0 to 5.4.1.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 2 versions ahead of your current version.

  • The recommended version was released on 3 years ago.

Release notes
Package name: ora from ora GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

@SherfeyInv
SherfeyInv merged commit 2d7092a into master Jun 30, 2024
@SherfeyInv
SherfeyInv deleted the snyk-upgrade-fcc49cd8969831c78d6bccb6957f4814 branch June 30, 2024 10:05
SherfeyInv pushed a commit that referenced this pull request May 7, 2026
…on serialization fails (nrwl#33274)

## Current Behavior
We have tried to enable v8 serialization again... but it still seems
problematic. We don't want to revert again... so we evaluated some
options:

1. Disable by default
2. Disable for the single client method we think may be problematic
3. Fall back to JSON if v8 fails
4. Disable by default and still fall back if JSON fails

## Expected Behavior
We decided to update Nx such that the default behavior will be a
combination of #4, and #2. So by default we use JSON, if that
serialization fails we'll try v8... but there's an exception so the
method we know to be an issue will never try v8.

If you opt in to v8 by default, the combo changes to #3 + #2. So, by
default we'd use v8... if it fails try json... never try v8 for
processInBackground

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
SherfeyInv pushed a commit that referenced this pull request Aug 17, 2026
…rwl#34927)

## Description

Fixes an infinite restart loop in `nx serve` that occurs when using the
`@nx/webpack:webpack` executor with a standard `webpack.config.js`
(non-composable path).

The root cause is that the `watch` option from the executor is not
propagated to the webpack configuration object when the `withNx()`
helper is bypassed. Because `config.watch` remains undefined,
`runWebpack()` defaults to a single-run build and completes the
observable immediately. The `@nx/js:node` executor interprets this
completion as a signal to restart the process, creating a loop every ~2
seconds regardless of file changes.

This was previously "accidentally" working for users of the composable
path (`withNx`) because that utility handles the flag internally. This
fix ensures the standard plugin path is also respected.

## Current Behavior
Using a plain `webpack.config.js` with the `NxAppWebpackPlugin` results
in `watch` being set to `undefined` in the final config.

```javascript
// webpack.config.js
const { NxAppWebpackPlugin } = require('@nx/webpack/app-plugin');

module.exports = {
  plugins: [new NxAppWebpackPlugin({ target: 'node', ... })],
};
```

Running `nx serve` triggers a build, the observable completes, and the
Node process restarts indefinitely.

## Expected Behavior
The `options.watch` flag from the executor should be forwarded to the
final webpack config. This ensures the build observable remains open
between rebuilds, preventing unnecessary process restarts.

## How to Verify
1. Create a Node/NestJS application using a standard `webpack.config.js`
(not using `composePlugins`).
2. Run `nx serve <app-name>`.
3. Verify the application stays alive after the initial build and only
restarts when a file change is detected.

## Results
### BEFORE fix — 25 seconds of output:
```
[Nest] 91794  - started  08:45:13
[Nest] 91807  - started  08:45:13   ← restart #1, <1 second later
[Nest] 91820  - started  08:45:14   ← restart #2
[Nest] 91833  - started  08:45:14   ← restart #3
[Nest] 91846  - started  08:45:15   ← restart #4
... 20+ restarts, every ~1 second, with no file changes
```

### After fix 
```
[Nest] 92962  - started  08:45:53
                                    ← stays alive for the entire duration
                                    ← one PID, no restarts
                                    ← exited cleanly on timeout
```

## Related Issue(s)
Fixes nrwl#22945

Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants