Skip to content

Add new and improved license and rules - #1357

Merged
pombredanne merged 13 commits into
developfrom
new-and-improved-license-rules3
Feb 9, 2019
Merged

Add new and improved license and rules#1357
pombredanne merged 13 commits into
developfrom
new-and-improved-license-rules3

Conversation

@pombredanne

Copy link
Copy Markdown
Member

Beside a few new licenses and several new license rules, this also add support for quoted SPDX expressions and and these comment marker prefixes.
This also contains a fix #1352 and an update to #1351

Add several new rules to improve corner cases of GPL and LGPL detection

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Comment markers include dnlk, list and rem and expressions can be
quoted at times. This add the support for a single comment word

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Softfloat v2 is frequent enough to be its own license
The bsd-1-clause-build is found in pplwrt build scripts

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
for short LGPL 3 tags

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reported-by: Frank Viernau <frank.viernau@here.com>
Reported-by: @DennisClark
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This is a short term fix until we have a proper review and revamp
of the categories

Reported-by: Till Jaeger @LeChasseur
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
apache-due-credit and classworlds are duplicates of dom4j
And dom4j is the most common one seen today.
All of these license are Apache-1.1-based with an extra "due credit"
clause.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@LeChasseur this is another weirdness:
See http://www.sql-workbench.net/manual/license.html

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@codecov

codecov Bot commented Feb 9, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1357 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #1357      +/-   ##
==========================================
- Coverage    84.22%   84.2%   -0.02%     
==========================================
  Files          117     117              
  Lines        13175   13194      +19     
==========================================
+ Hits         11096   11110      +14     
- Misses        2079    2084       +5
Impacted Files Coverage Δ
src/licensedcode/index.py 80.88% <0%> (-0.86%) ⬇️
src/licensedcode/query.py 88.73% <0%> (-0.63%) ⬇️
src/licensedcode/frequent_tokens.py 100% <0%> (ø) ⬆️
src/scancode/cli.py 76.88% <0%> (+0.15%) ⬆️
src/licensedcode/match_spdx_lid.py 83.97% <0%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a763b50...65efc01. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Feb 9, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1357 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #1357      +/-   ##
==========================================
- Coverage    84.22%   84.2%   -0.02%     
==========================================
  Files          117     117              
  Lines        13175   13194      +19     
==========================================
+ Hits         11096   11110      +14     
- Misses        2079    2084       +5
Impacted Files Coverage Δ
src/licensedcode/index.py 80.88% <0%> (-0.86%) ⬇️
src/licensedcode/query.py 88.73% <0%> (-0.63%) ⬇️
src/licensedcode/frequent_tokens.py 100% <0%> (ø) ⬆️
src/scancode/cli.py 76.88% <0%> (+0.15%) ⬆️
src/licensedcode/match_spdx_lid.py 83.97% <0%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a763b50...65efc01. Read the comment docs.

@pombredanne

Copy link
Copy Markdown
Member Author

All green. Merging!

@pombredanne
pombredanne merged commit 5938d20 into develop Feb 9, 2019
@pombredanne
pombredanne deleted the new-and-improved-license-rules3 branch February 9, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

License classification for fraunhofer-fdk-aac-codec

1 participant