openclaw ACP adapter: pending prompts are never reconciled when the SSE event stream reconnects (#3997) #4617

Activity

1. dezren39

   added

   task/triageQueue packet kind: verify, reproduce, and route this itemQueue packet kind: verify, reproduce, and route this item

   status/needs-triageNot yet triaged; needs a first lookNot yet triaged; needs a first look

   priority/normalOrdinary priority (the default)Ordinary priority (the default)

   queue/queuedHas a queued task in the Supabase agent queueHas a queued task in the Supabase agent queue

   source/pr-comment-reviewFiled by the pr-comment-review jobFiled by the pr-comment-review job

   on Nov 2, 2026
2. dezren39 commented on Nov 2, 2026

   

   dezren39

   on Nov 2, 2026

   MemberAuthor

   More actions

   🤖 Agent note · filed

   • Agent: pr-comment-review job
   • Session / ID: pr-comment-review cron run 2026-11-02 15:54 CST (2026-11-02T22:14:31Z)
   • Found via: unaddressed PR comment — PR feat(openclaw): ACP-to-HTTP adapter so OpenClaw shares the standing opencode serve (#1243) #3997, Codex comment feat(openclaw): ACP-to-HTTP adapter so OpenClaw shares the standing opencode serve (#1243) #3997 (comment)
   • Task: Triage the validated finding: pending prompts are never reconciled when the SSE event stream reconnects, so a prompt completed during the gap hangs indefinitely (thread unresolved, no reply, no post-comment fix commit, PR merged as-is, still live on current main)
   • Expectation: effort m — queue worker verifies against current main, then fixes or documents a decision
   • Links: issue openclaw ACP adapter: pending prompts are never reconciled when the SSE event stream reconnects (#3997) #4617 · source PR feat(openclaw): ACP-to-HTTP adapter so OpenClaw shares the standing opencode serve (#1243) #3997
3. dezren39 commented on Nov 2, 2026

   

   dezren39

   on Nov 2, 2026

   MemberAuthor

   More actions

   🤖 Agent note · picked up

   • Agent: queue worker (repo-worker-code), lane code-a
   • Session / ID: task 6519
   • Found via: queue claim
   • Task: triage task 6519 for issue openclaw ACP adapter: pending prompts are never reconciled when the SSE event stream reconnects (#3997) #4617 — verify against current main that the SSE reconnect loop in bin/opencode-acp-adapter.mjs never reconciles pendingPrompts, then route the fix.
   • Expectation: s; triage verdict posted with fresh evidence, and a follow-up fix task enqueued if confirmed.
   • Links: PR feat(openclaw): ACP-to-HTTP adapter so OpenClaw shares the standing opencode serve (#1243) #3997 (merged; origin of the Codex P2 cited on issue openclaw ACP adapter: pending prompts are never reconciled when the SSE event stream reconnects (#3997) #4617)
4. dezren39

   added

   work/assignedQueue worker lifecycle stateQueue worker lifecycle state

   queue/claimedQueue worker lifecycle stateQueue worker lifecycle state

   status/in-progressQueue worker lifecycle stateQueue worker lifecycle state

   and removed

   status/needs-triageNot yet triaged; needs a first lookNot yet triaged; needs a first look

   queue/queuedHas a queued task in the Supabase agent queueHas a queued task in the Supabase agent queue

   on Nov 2, 2026
5. dezren39 commented on Nov 2, 2026

   

   dezren39

   on Nov 2, 2026

   MemberAuthor

   More actions

   🤖 Agent note · triaged — CONFIRMED on current main

   • Agent: queue worker (repo-worker-code), lane code-a
   • Session / ID: task 6519
   • Found via: queue claim (triage)
   • Task: triage task 6519 for issue openclaw ACP adapter: pending prompts are never reconciled when the SSE event stream reconnects (#3997) #4617 — verdict: CONFIRMED, fresh on main 9f730f1c22efc3ebc4605c63d7813e962f596ec5 (2026-11-02).

   Fresh evidence (all read this shift via gh):

   • Issue openclaw ACP adapter: pending prompts are never reconciled when the SSE event stream reconnects (#3997) #4617 is OPEN with no hard-stop labels; PR feat(openclaw): ACP-to-HTTP adapter so OpenClaw shares the standing opencode serve (#1243) #3997 is MERGED (2026-11-02T15:44Z); no open PR references issue openclaw ACP adapter: pending prompts are never reconciled when the SSE event stream reconnects (#3997) #4617.
   • bin/opencode-acp-adapter.mjs (496 lines on current main), runEventStream (:162-191): the loop fetches GET /event, and on stream close logs event stream closed; reconnecting, on error logs …; reconnecting, waits 1000 ms (:189) and retries. Nothing in the loop reads or touches pendingPrompts — no reconciliation, no status query, no resolve/reject on reconnect.
   • pendingPrompts (:127) entries are removed only by finishPrompt (:286-294), which is called only from handleServeEvent on a session.idle event (:307-313) or a session.error event (:314-320), plus a delete when the prompt_async POST itself throws (:413). A session.idle emitted server-side while the stream is down never reaches handleServeEvent, so the entry — and the deferred ACP response — stays pending forever. There is no pending-prompt timeout anywhere in the file (the only setTimeouts are the event-stream ready wait at :154 and the 1 s reconnect delay at :189).
   • Consequence confirmed in code: session/prompt (:399-401) throws already has a prompt in flight while an entry lingers, so later prompts for that session are rejected indefinitely even after the stream reconnects — exactly the Codex P2 on PR feat(openclaw): ACP-to-HTTP adapter so OpenClaw shares the standing opencode serve (#1243) #3997 (comment r4437436115).
   • Test gap confirmed: bin/opencode-acp-adapter.test.mjs (262 lines) drives a stub SSE stream and covers completion on session.idle, but contains no reconnect/drop test (no occurrence of reconnect in the file).

   Routing: a small_fix follow-up task has been enqueued from this triage: on event-stream reconnect, reconcile each pending prompt against the server's current session state (resolve/reject accordingly) or explicitly fail it when event continuity was lost, plus a drop-and-complete test using the existing stub harness. Note for sequencing: issue #4614 (triage task 6516) covers migrating this same adapter to the standing server's v2 session contract — if that migration lands first, implement the reconciliation against the v2 contract instead of the v1 prompt_async flow.
6. dezren39 commented on Nov 2, 2026

   

   dezren39

   on Nov 2, 2026

   MemberAuthor

   More actions

   🤖 Agent note · done

   • Agent: queue worker (repo-worker-code), lane code-a
   • Session / ID: task 6519
   • Found via: queue claim (triage)
   • Task: triage task 6519 for issue openclaw ACP adapter: pending prompts are never reconciled when the SSE event stream reconnects (#3997) #4617 is complete — CONFIRMED fresh on main 9f730f1c (full evidence in the triage note above on issue openclaw ACP adapter: pending prompts are never reconciled when the SSE event stream reconnects (#3997) #4617). Follow-up fix enqueued as task 6535 (small_fix: reconcile pending prompts on event-stream reconnect + drop-and-complete test); issue openclaw ACP adapter: pending prompts are never reconciled when the SSE event stream reconnects (#3997) #4617 stays OPEN pending that fix.
   • Expectation: task 6535 implements the acceptance criteria on issue openclaw ACP adapter: pending prompts are never reconciled when the SSE event stream reconnects (#3997) #4617.
   • Links: task 6535; PR feat(openclaw): ACP-to-HTTP adapter so OpenClaw shares the standing opencode serve (#1243) #3997 (merged, origin of the finding); issue openclaw ACP adapter: use the standing server's v2 session API — v1 /session + prompt_async contract cannot create working sessions (#3997) #4614 (sibling adapter migration)
7. dezren39

   added

   queue/queuedHas a queued task in the Supabase agent queueHas a queued task in the Supabase agent queue

   on Nov 2, 2026
8. 57 remaining items

   Load more

9. developing-today commented on Nov 8, 2026

   

   developing-todayBot

   on Nov 8, 2026 – with developing.today

   Contributor

   More actions

   🤖 Agent note · done

   • Agent: queue worker (repo-worker-code), lane code-n
   • Session / ID: task 12170
   • Found via: queue claim
   • Task: triage of the remainder on issue openclaw ACP adapter: pending prompts are never reconciled when the SSE event stream reconnects (#3997) #4617 (openclaw ACP adapter: pending prompts never reconciled on SSE reconnect)
   • Verdict: REAL and CURRENT — confirmed against current main a23b3ce454:
     • bin/opencode-acp-adapter.mjs:196 — pendingPrompts Map (acpSessionId → {requestId}).
     • runEventStream (~lines 229–259) — on stream close/error it logs "reconnecting", waits 1s, and reconnects; it never reconciles, resolves, or rejects entries in pendingPrompts and never queries current session status. Entries are removed only on terminal serve events, prompt-post error, or cancel — all event-driven — so a terminal event lost during a disconnect still hangs the ACP request indefinitely and later prompts are rejected as already in flight.
     • PR fix(acp-adapter): migrate to the standing server's v2 session API (#4614) #4698 (v2 session migration) changed the event model but not this path; bin/opencode-acp-adapter.test.mjs (375 lines) has no reconnect/stream-drop test.
   • Routing: remainder converted to a fix packet — task 12842 (small_fix, dedupe repo-health:v1:fix:developing-today/code:issue:4617), scoped to the reconnect-reconciliation remainder only. Per Drew's triage doctrine (code#7016), this triage completion does not close issue openclaw ACP adapter: pending prompts are never reconciled when the SSE event stream reconnects (#3997) #4617; it returns to the queue for real work as task 12842.
   • Expectation: task 12842 lands the reconciliation + reconnect test and closes this issue via a merged PR with a closing keyword.
10. developing-today

    added

    status/triagedTriaged and routed (see agent note)Triaged and routed (see agent note)

    and removed

    queue/parkedQueue task is parked (waiting on CI, time, or an event)Queue task is parked (waiting on CI, time, or an event)

    status/parkedDeliberately paused with a recorded resume conditionDeliberately paused with a recorded resume condition

    work/assignedQueue worker lifecycle stateQueue worker lifecycle state

    on Nov 8, 2026
11. developing-today commented on Nov 8, 2026

    

    developing-todayBot

    on Nov 8, 2026 – with developing.today

    Contributor

    More actions

    🤖 Agent note · picked up

    • Agent: queue worker (repo-worker-code), lane code-t
    • Session / ID: task 12170
    • Found via: queue claim
    • Task: Re-triage of issue openclaw ACP adapter: pending prompts are never reconciled when the SSE event stream reconnects (#3997) #4617 (task 12170, remainder after partial verification): verify the ACP adapter pending-prompts finding against current main, record the verdict, and if real convert to a fix packet returning it to the queue for real work.
    • Expectation: triage (s) — verdict comment on issue openclaw ACP adapter: pending prompts are never reconciled when the SSE event stream reconnects (#3997) #4617 plus a scoped fix packet if real; issue openclaw ACP adapter: pending prompts are never reconciled when the SSE event stream reconnects (#3997) #4617 stays open unless validated invalid.
    • Links: issue openclaw ACP adapter: pending prompts are never reconciled when the SSE event stream reconnects (#3997) #4617; source PR feat(openclaw): ACP-to-HTTP adapter so OpenClaw shares the standing opencode serve (#1243) #3997
12. developing-today

    added

    queue/claimedQueue worker lifecycle stateQueue worker lifecycle state

    work/assignedQueue worker lifecycle stateQueue worker lifecycle state

    status/in-progressQueue worker lifecycle stateQueue worker lifecycle state

    on Nov 8, 2026
13. developing-today commented on Nov 8, 2026

    

    developing-todayBot

    on Nov 8, 2026 – with developing.today

    Contributor

    More actions

    🤖 Agent note · triaged (remainder after partial verification)

    • Agent: queue worker (repo-worker-code), lane code-t
    • Session / ID: task 12170
    • Found via: queue claim
    • Task: Re-triage openclaw ACP adapter: pending prompts are never reconciled when the SSE event stream reconnects (#3997) #4617 on current state: verdict, annotate, convert to a fix packet if real
    • Expectation: done = verdict recorded here + the fix returned to the queue as a fix packet; the issue closes only when the fix lands, never via triage

    Verdict: REAL AND CURRENT (verified fresh 2026-11-08, lane code-t):

    • Issue openclaw ACP adapter: pending prompts are never reconciled when the SSE event stream reconnects (#3997) #4617 is OPEN, no hard-stop labels. The Codex P2 finding from PR feat(openclaw): ACP-to-HTTP adapter so OpenClaw shares the standing opencode serve (#1243) #3997 (merged 2026-11-02 as-is; review thread discussion_r4437436115 never answered) is still live on origin/main b7b7f596e4e9.
    • Direct code evidence: in bin/opencode-acp-adapter.mjs, runEventStream's reconnect loop (~lines 230–262) logs "event stream closed; reconnecting", waits 1s, and retries — nothing reconciles, resolves, or rejects pendingPrompts on reconnect. Prompt completion is deferred entirely to serve terminal events (session/prompt registers pendingPrompts and returns undefined; finishPrompt fires on session.execution.succeeded/.failed), so a terminal event lost during a drop leaves the ACP request pending indefinitely, and the next prompt is rejected as already in flight (~line 469) even after reconnect.
    • Test home exists: bin/opencode-acp-adapter.test.mjs is on main alongside the adapter.

    Disposition: the fix packet for this issue already exists in the queue as task 12842 (dedupe repo-health:v1:fix:developing-today/code:issue:4617, queued 2026-11-08T04:59:48Z — my enqueue attempt deduped against it, no duplicate created). Its scope is the acceptance on this issue: reconcile pending prompts against server session state after reconnect (or explicitly fail them when continuity was lost), plus the drop+completion regression test, preserving the #4618 cancel-marker semantics. Issue #4617 stays OPEN.
14. developing-today

    added

    queue/queuedHas a queued task in the Supabase agent queueHas a queued task in the Supabase agent queue

    and removed

    status/in-progressQueue worker lifecycle stateQueue worker lifecycle state

    queue/claimedQueue worker lifecycle stateQueue worker lifecycle state

    work/assignedQueue worker lifecycle stateQueue worker lifecycle state

    status/triagedTriaged and routed (see agent note)Triaged and routed (see agent note)

    on Nov 8, 2026