Repository navigation
fix(acp-adapter): migrate to the standing server's v2 session API (#4614) - #4698
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 23 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrates
bin/opencode-acp-adapter.mjsfrom the v1 session contract to the standing server's v2 session API (issue #4614), with the contract test re-expressed in v2 shapes. Queue task 6571.v2 contract (probed live from the standing server, not guessed)
Pinned from the server's own OpenAPI (
/openapi.json) plus a live event-stream capture and a full probe prompt cycle against127.0.0.1:13420:POST /api/sessionwithlocation.directoryin the body; responses carry a{data}envelope (adapter now unwraps it, mirroringpm-stack/dispatch/src/opencode.ts)POST /api/session/:id/promptwith{text, files}— there is no parts array in v2; text-bearing ACP blocks concatenate intotext, binary/link blocks becomefilesattachments by URI (data: URIs for embedded content)GET /api/event, frames{type, data}— the v2 event model issession.text.delta/session.reasoning.deltafor streaming andsession.execution.succeeded/session.execution.failedfor prompt completion (nomessage.part.updated/session.idle)permission.askedevent carries a v2Permission.Request({id, sessionID, action, resources, metadata}); reply isPOST /api/session/:id/permission/:requestID/replywith{decision: once|always|reject}POST /api/session/:id/interruptVerification
node --test bin/opencode-acp-adapter.test.mjs— 8/8 pass on the laptop (v2-shaped stub harness: create/prompt/stream/permission/cancel + the openclaw ACP adapter: load the standing-server credential — gateway launch wires no OPENCODE_SERVER_PASSWORD (#3997) #4615 credential tests unchanged in behavior)initialize→session/new(real session created) →session/promptstreamedadapter-v2-okassession/updateand resolvedend_turn. Probe session deleted afterwards.Interaction with PR #4632 (#4617)
PR #4632 (reconnect reconcile) is still open on the v1 routes (
/session/status). It is a separate queue task's PR and is not ported here; it will need its reconcile re-based onto the v2 surface (GET /api/sessionlist) after this lands. Flagging rather than silently competing.Refs #4614
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.