github-backup(ghb_common): inventory_owner paginates forever when a page says hasNextPage with a null/empty endCursor — the reconcile sweep hangs re-fetching page 1 instead of raising

infra/github-backup/bin/ghb_common.py inventory_owner() (the GraphQL inventory every github-backup consumer builds on: the weekly reconcile.py sweep, clone_all.py planning, manifest regeneration) advances its pagination cursor with no validation: when a page reports hasNextPage: true, the loop takes pageInfo.endCursor as the next after unconditionally (ghb_common.py:126-127). If that cursor is null (or empty), after stays falsy, the after variable is omitted from the next request (:75-77), and the loop re-fetches the first page forever — appending the same repos on every iteration, issuing a real gh api graphql call each time, never returning. Every other malformed-response shape in this function was hardened to raise instead of being misread (#3229: top-level errors, null repositoryOwner, null repositories connection, missing nodes/pageInfo all raise RuntimeError); the non-advancing cursor is the one malformed shape left unguarded.

Evidence (file:line, origin/main `2bcd46e0dc`)

ghb_common.py:126-127: if conn["pageInfo"]["hasNextPage"]: after = conn["pageInfo"]["endCursor"] — no check that the cursor is a non-empty string, and no check that it differs from the cursor just used. A repeated (stuck) cursor loops the same way.
ghb_common.py:75-77: the next request includes after only if after: — a null/empty cursor therefore silently restarts at page 1 rather than failing.
ghb_common.py:96-124 (contrast): the function's own stated contract — a successful gh exit carrying a failed/malformed inventory must raise, never be read as data (github-backup(inventory): a null repositoryOwner is silently read as 'this owner has no repos' — reconcile drops the owner's mirrors from plan.json and MANIFEST.json and exits 0 #3229 comment, :96-102). The cursor path violates that contract by hanging instead of raising.
Callers hang with it: reconcile.py main() calls inventory(cfg["owners"]) → inventory_owner per owner before any plan/report is written, so one malformed page wedges the whole weekly correctness sweep (its timer surfaces failures via exit code — a hang surfaces nothing).

Verification (laptop probe, this run)

Probe ~/git/fleet/probe-ghb-cursor/ against the real ghb_common.py at origin/main 2bcd46e0dc, with ghb_common.run stubbed to return canned GraphQL pages:

Malformed page (hasNextPage: true, endCursor: null, one node): inventory_owner was still looping after 6 identical page fetches — the probe aborted it there; without the abort it never returns (each iteration appends a duplicate repo and makes another API call).
Control (two well-formed pages, cursors c1 → c2, second page hasNextPage: false): returns 2 repos in exactly 2 calls.

Why it matters

The reconcile sweep is the github-backup system's correctness floor — the guarantee that no repo is missed. A single malformed pagination response (API change, partial response, proxy-mangled page) turns it into a silent infinite loop: no report, no exit-code failure for the timer to surface, unbounded duplicate accumulation in memory, and a stream of identical GraphQL calls against the API quota until something external kills it. The function's other malformed shapes all fail loud within one call; this one should too.

Acceptance criteria

inventory_owner raises RuntimeError (the function's existing failure mode, naming the owner and the malformed cursor) when a page reports hasNextPage: true with a null, empty, or non-advancing (same-as-just-used) endCursor, instead of issuing another request.
Well-formed multi-page inventories are unchanged: pages are fetched in order, each repo appears once, and the final page's hasNextPage: false ends the loop (existing test_inventory_owner.py suite passes unchanged).
A regression test in infra/github-backup/tests/test_inventory_owner.py pins the malformed-cursor page: the stubbed transport is called a bounded number of times and the call raises.
inventory()'s per-owner error recording picks the failure up as an owner-level error (the github-backup(inventory): a null repositoryOwner is silently read as 'this owner has no repos' — reconcile drops the owner's mirrors from plan.json and MANIFEST.json and exits 0 #3229 path), so reconcile.py reports it and exits non-zero rather than hanging.

Filed by the new-issue-creator (lane B) after verification this run; not a duplicate of #3229/#3240 (state-file atomicity) or #3282/#3283 (github-backup contracts/audit) — this is the pagination loop's missing cursor guard specifically.

CODE-1984

🤖 Agent note · filed

Agent: new-issue-creator (lane B, new-issue-creator-code-b)
Session / ID: cron new-issue-creator-code-b, run 2026-11-06 08:50 CST
Found via: filed this run
Task: Triage the inventory_owner pagination-cursor hang: confirm the non-advancing endCursor loop in infra/github-backup/bin/ghb_common.py and route the raise-instead-of-loop fix with a regression test.
Expectation: effort s — done looks like a triage verdict on this issue, then a fix that raises RuntimeError on a null/empty/repeated cursor with the existing test_inventory_owner.py suite green.
Links: probe ~/git/fleet/probe-ghb-cursor/ (laptop); body file hidden_files/issue-ghb-inventory-cursor-loop.md

agent-note:v1

task: 11190
lane: code-l
event: picked_up
detail: Claimed by lane code-l for triage of issue github-backup(ghb_common): inventory_owner paginates forever when a page says hasNextPage with a null/empty endCursor — the reconcile sweep hangs re-fetching page 1 instead of raising #6532 (direct execution lane). Verifying the reported pagination defect against current main before routing.

🤖 Agent note · picked up

Agent: queue worker (repo-worker-code), lane code-l
Session / ID: task 11190
Found via: queue claim
Task: triage issue github-backup(ghb_common): inventory_owner paginates forever when a page says hasNextPage with a null/empty endCursor — the reconcile sweep hangs re-fetching page 1 instead of raising #6532 — confirm the inventory_owner null/empty endCursor pagination defect at current main, scope the fix path, record blockers/ordering
Expectation: findings posted on issue github-backup(ghb_common): inventory_owner paginates forever when a page says hasNextPage with a null/empty endCursor — the reconcile sweep hangs re-fetching page 1 instead of raising #6532 with file:line evidence; fix routed as a follow-up task if the defect is confirmed
Links: issue github-backup(ghb_common): inventory_owner paginates forever when a page says hasNextPage with a null/empty endCursor — the reconcile sweep hangs re-fetching page 1 instead of raising #6532 — github-backup(ghb_common): inventory_owner paginates forever when a page says hasNextPage with a null/empty endCursor — the reconcile sweep hangs re-fetching page 1 instead of raising #6532

agent-note:v1

task: 11193
lane: 7b47536b-c162-444c-be8a-3a9538cc4cb5
event: picked_up
detail: Claimed the small-fix task in this OpenChamber scheduled lane. Fresh GitHub check: issue is OPEN, no hard-stop labels, and no matching PR is open or closed; prior parked labels were synchronized to in-progress. Revalidating the current code and preparing an isolated worktree.

🤖 Agent note · picked up

Agent: queue worker (repo-worker-code), OpenChamber scheduled lane 7b47536b-c162-444c-be8a-3a9538cc4cb5
Session / ID: task 11193
Found via: queue claim
Task: fix github-backup(ghb_common): inventory_owner paginates forever when a page says hasNextPage with a null/empty endCursor — the reconcile sweep hangs re-fetching page 1 instead of raising #6532: reject null, empty, or non-advancing pagination endCursor in inventory_owner, with regression coverage
Expectation: bounded regression test and targeted suite pass; no parallel PR exists.
Links: github-backup(ghb_common): inventory_owner paginates forever when a page says hasNextPage with a null/empty endCursor — the reconcile sweep hangs re-fetching page 1 instead of raising #6532

agent-note:v1

task: 11193
lane: 7b47536b-c162-444c-be8a-3a9538cc4cb5
event: pr_opened
detail: Implemented malformed-cursor validation and regression coverage; pushed commit 7520e69 and opened PR fix(github-backup): reject malformed inventory pagination cursors #6574. Focused suite passes 36/36 and both files compile.

🤖 Agent note · PR opened

Agent: queue worker (repo-worker-code), OpenChamber scheduled lane 7b47536b-c162-444c-be8a-3a9538cc4cb5
Session / ID: task 11193
Found via: queue claim
Task: fix github-backup(ghb_common): inventory_owner paginates forever when a page says hasNextPage with a null/empty endCursor — the reconcile sweep hangs re-fetching page 1 instead of raising #6532: stop inventory_owner from looping on null, empty, or repeated endCursor values
Expectation: cursor errors raise with owner/cursor context; the inventory error path remains owner-scoped.
Links: PR fix(github-backup): reject malformed inventory pagination cursors #6574 — fix(github-backup): reject malformed inventory pagination cursors #6574; issue github-backup(ghb_common): inventory_owner paginates forever when a page says hasNextPage with a null/empty endCursor — the reconcile sweep hangs re-fetching page 1 instead of raising #6532

agent-note:v1

task: 11193
lane: 7b47536b-c162-444c-be8a-3a9538cc4cb5
event: parked
detail: PR fix(github-backup): reject malformed inventory pagination cursors #6574 is open; PR checks basic: scripts-test (3.12) and (3.14) remained queued after the short CI poll. Task parked for 20 minutes, resuming after checks complete. Full github-backup test suite passed locally.

🤖 Agent note · parked

Agent: queue worker (repo-worker-code), OpenChamber scheduled lane 7b47536b-c162-444c-be8a-3a9538cc4cb5
Session / ID: task 11193
Resume condition: PR fix(github-backup): reject malformed inventory pagination cursors #6574 checks complete; revalidate issue/PR state, then merge if checks are green and the diff remains in scope.
Links: fix(github-backup): reject malformed inventory pagination cursors #6574; github-backup(ghb_common): inventory_owner paginates forever when a page says hasNextPage with a null/empty endCursor — the reconcile sweep hangs re-fetching page 1 instead of raising #6532

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-a
Session / ID: task 11193
Found via: queue claim
Task: handing task 11193 (issue github-backup(ghb_common): inventory_owner paginates forever when a page says hasNextPage with a null/empty endCursor — the reconcile sweep hangs re-fetching page 1 instead of raising #6532) to the opencode claimant per execution-lane assignment; claimant launches the bound opencode session
Expectation: claimant picks up task 11193; if not launched before lease/park expiry, task 11193 returns to the queue
Links: issue github-backup(ghb_common): inventory_owner paginates forever when a page says hasNextPage with a null/empty endCursor — the reconcile sweep hangs re-fetching page 1 instead of raising #6532

🤖 Agent note · handed off

Agent: repo queue worker, lane code-r (repo-worker-code)
Session / ID: cron repo-queue-worker-shift-r run 2026-11-06; task 11193
Found via: claimed task 11193 this shift; execution-lane assignment returned opencode
Task: task 11193 for issue github-backup(ghb_common): inventory_owner paginates forever when a page says hasNextPage with a null/empty endCursor — the reconcile sweep hangs re-fetching page 1 instead of raising #6532 (small_fix). Fresh check: issue github-backup(ghb_common): inventory_owner paginates forever when a page says hasNextPage with a null/empty endCursor — the reconcile sweep hangs re-fetching page 1 instead of raising #6532 is OPEN, no hard-stop labels (held / user/owned / do-not-merge / do-not-auto-edit). PR fix(github-backup): reject malformed inventory pagination cursors #6574 is OPEN on branch queue/11193-6532-inventory-cursor-fix and is the canonical PR for this task — not touched by this lane. Handed off to the opencode claimant; this lane does not work it directly. Attempts 1/6.
Expectation: claimant session drives task 11193 to a terminal state.
Links: task 11193 · issue github-backup(ghb_common): inventory_owner paginates forever when a page says hasNextPage with a null/empty endCursor — the reconcile sweep hangs re-fetching page 1 instead of raising #6532 · PR fix(github-backup): reject malformed inventory pagination cursors #6574

🤖 Agent note · design-architect pass 63 — adopted as a phase of design #6622

Design: Design: complete, bounded, or say so — one pagination contract for the repo's paged reads #6622 — complete, bounded, or say so (one pagination contract for the repo's paged reads). Doc: files/designs/code-pagination-contract.md in the keep-the-four-repos-healthy goal workspace. Audit at origin/main 075b2de90
This issue is Phase 2 (volume bounds on fresh-cursor streams), with the other Phase 2 issues (github-backup(drain): queue_events pagination has no page/event bound — a Worker page stream with fresh cursors and list_complete=false loops forever, accumulating events and never acking #6572, cold-store-reaper(listings): list_backups and s3_list_objects have no page/result bound — a fresh-token page stream loops forever, accumulating rows #6602). Linked as a sub-issue of Design: complete, bounded, or say so — one pagination contract for the repo's paged reads #6622 (verified in its sub_issues list). Independent of Phase 1 in code
Decision recorded on Design: complete, bounded, or say so — one pagination contract for the repo's paged reads #6622 that binds this phase: every page loop carries a page-count and/or accumulated-result bound, sized generously above any legitimate listing, whose breach is an error naming the listing — the bound's exact value stays with this phase's fixer as a named constant; a fresh-token stream ending in a hang is the one forbidden outcome
For triage: do NOT re-file, re-scope or split this issue as a standalone — record the phase structure instead. No new packet from the architect: this issue already carries its own queue lifecycle

Navigation Menu

Repository navigation

github-backup(ghb_common): inventory_owner paginates forever when a page says hasNextPage with a null/empty endCursor — the reconcile sweep hangs re-fetching page 1 instead of raising #6532

github-backup(ghb_common): inventory_owner paginates forever when a page says hasNextPage with a null/empty endCursor — the reconcile sweep hangs re-fetching page 1 instead of raising

Evidence (file:line, origin/main `2bcd46e0dc`)

Verification (laptop probe, this run)

Why it matters

Acceptance criteria

12 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

github-backup(ghb_common): inventory_owner paginates forever when a page says hasNextPage with a null/empty endCursor — the reconcile sweep hangs re-fetching page 1 instead of raising #6532

Description

github-backup(ghb_common): inventory_owner paginates forever when a page says hasNextPage with a null/empty endCursor — the reconcile sweep hangs re-fetching page 1 instead of raising

Evidence (file:line, origin/main 2bcd46e0dc)

Verification (laptop probe, this run)

Why it matters

Acceptance criteria

Activity

developing-today commented on Nov 6, 2026

dezren39 commented on Nov 6, 2026

dezren39 commented on Nov 6, 2026

12 remaining items

dezren39 commented on Nov 6, 2026

dezren39 commented on Nov 6, 2026

dezren39 commented on Nov 6, 2026

dezren39 commented on Nov 6, 2026

dezren39 commented on Nov 6, 2026

dezren39 commented on Nov 6, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Evidence (file:line, origin/main `2bcd46e0dc`)