Skip to content

fix(github-backup): reject malformed inventory pagination cursors - #6574

Open
dezren39 wants to merge 1 commit into
mainfrom
queue/11193-6532-inventory-cursor-fix
Open

dezren39 wants to merge 1 commit into
mainfrom
queue/11193-6532-inventory-cursor-fix

Conversation

@dezren39

@dezren39 dezren39 commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Summary

 if hasNextPage:
-  after = endCursor
+  require a non-empty cursor not previously used
+  otherwise raise RuntimeError naming the owner and cursor

Adds bounded regression coverage for null, empty, and repeated cursors. inventory() records the failure as an owner-level error, preserving the existing reconcile failure path.

Evidence

Merge Danger

Door: Two-way.

Blast Radius: Low — only GitHub-backup owner pagination and its focused test file.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 6, 2026 17:07
@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 41 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f9955421-7a6a-40b8-8c79-2ff62d5c5a42
Commits

Reviewing files that changed from the base of the PR and between 16ffcf5 and 7520e69.

Files selected for processing: 2

  • infra/github-backup/bin/ghb_common.py
  • infra/github-backup/tests/test_inventory_owner.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T17:09:04.658752Z 7520e69 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant