Skip to content

test(id-e2e): fix editor-features image test defects (#1228) - #1238

Merged
dezren39 merged 1 commit into
mainfrom
queue/1249-1228-editor-test-defects
Oct 30, 2026
Merged

dezren39 merged 1 commit into
mainfrom
queue/1249-1228-editor-test-defects

Conversation

@dezren39

@dezren39 dezren39 commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Fixes #1228 (filed from queue task 1240's classification of the 13 within-spec Firefox failures on #229, dispatch run 40402931464).

Two proven test defects, no product code changes:

  1. :1098 image node renders — the uploaded image did render (correct /blob/… src in the failure block), but page.locator("#editor .ProseMirror img") also matches ProseMirror's internal <img class="ProseMirror-separator">, so toBeVisible() failed strict mode on both attempts. Locator now scoped to img.pm-image.
  2. :1601 alt-text / :1665 resize — both POST /api/save with {name, doc} and no doc_id; SaveRequest.doc_id is a required String (routes.rs), so the payload was rejected before the handler and saveResp.ok() was deterministically false. Both tests now send doc_id: hash from their /api/new response, matching every passing save in the same spec.

A standalone codec probe verified PM→MD conversion of both exact image docs succeeds on main — conversion was never the failure.

Verification: TS syntax checked (Bun transpiler); the id e2e nightly workflow is dispatched on this branch — the three tests passing in that isolated Firefox run is the acceptance check. Queue task 1249.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

- :1098 scope the editor image locator to img.pm-image so it no longer
  also matches ProseMirror's internal ProseMirror-separator <img>
  (toBeVisible strict-mode violation; the uploaded image rendered fine).
- :1601/:1665 send doc_id from the /api/new response in the /api/save
  payload; SaveRequest.doc_id is required, so both saves were rejected
  before the handler and saveResp.ok() was deterministically false.

Proven test defects from queue task 1240's classification of dispatch
run 40402931464 on issue #229; no product code changes.
@dezren39
dezren39 requested a review from a team as a code owner October 27, 2026 04:10
@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 14 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0c6958f6-cec1-4f41-90f1-40ffb82aa880
Commits

Reviewing files that changed from the base of the PR and between bc9b67f and 4c7ff8f.

Files selected for processing: 1
  • pkgs/id/e2e/tests/editor-features.spec.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T04:11:24.932388Z 4c7ff8f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39

Copy link
Copy Markdown
Member Author

Heads-up from queue task 1249: this PR branched from current main, whose clippy-lint is currently broken by a pre-existing panic! in the #1043 MisplacedNode test (src/web/markdown.rs:1999, from PR #1089) — unrelated to this PR (TS-only diff). Tracked as #1245 with a fix enqueued (queue task 1264); this branch will need a main update / CI re-run after that lands before its clippy job can go green.

@dezren39

Copy link
Copy Markdown
Member Author

Stale-PR warden: no activity for 2 days. Resolution task: #2357 — this PR should be merged, fixed, or closed.

@dezren39 dezren39 closed this Oct 30, 2026
@dezren39 dezren39 reopened this Oct 30, 2026
@dezren39
dezren39 added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit 4077d0c Oct 30, 2026
50 of 60 checks passed
@dezren39
dezren39 deleted the queue/1249-1228-editor-test-defects branch October 30, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

e2e: editor-features test defects — image locator strict-mode + save payloads missing doc_id (#229 follow-up)

1 participant