Repository navigation
test(id-e2e): fix editor-features image test defects (#1228) - #1238
Conversation
- :1098 scope the editor image locator to img.pm-image so it no longer also matches ProseMirror's internal ProseMirror-separator <img> (toBeVisible strict-mode violation; the uploaded image rendered fine). - :1601/:1665 send doc_id from the /api/new response in the /api/save payload; SaveRequest.doc_id is required, so both saves were rejected before the handler and saveResp.ok() was deterministically false. Proven test defects from queue task 1240's classification of dispatch run 40402931464 on issue #229; no product code changes.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 14 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Heads-up from queue task 1249: this PR branched from current main, whose |
|
Stale-PR warden: no activity for 2 days. Resolution task: #2357 — this PR should be merged, fixed, or closed. |
Fixes #1228 (filed from queue task 1240's classification of the 13 within-spec Firefox failures on #229, dispatch run 40402931464).
Two proven test defects, no product code changes:
/blob/…src in the failure block), butpage.locator("#editor .ProseMirror img")also matches ProseMirror's internal<img class="ProseMirror-separator">, sotoBeVisible()failed strict mode on both attempts. Locator now scoped toimg.pm-image./api/savewith{name, doc}and nodoc_id;SaveRequest.doc_idis a requiredString(routes.rs), so the payload was rejected before the handler andsaveResp.ok()was deterministically false. Both tests now senddoc_id: hashfrom their/api/newresponse, matching every passing save in the same spec.A standalone codec probe verified PM→MD conversion of both exact image docs succeeds on main — conversion was never the failure.
Verification: TS syntax checked (Bun transpiler); the
id e2e nightlyworkflow is dispatched on this branch — the three tests passing in that isolated Firefox run is the acceptance check. Queue task 1249.Need help on this PR? Tag
@codesmith-botwith what you need.