Skip to content

test(id-e2e): fix editor-features image test defects (#1228) #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dezren39 merged 1 commit into from
Oct 30, 2026
Merged

test(id-e2e): fix editor-features image test defects (#1228) #1238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions pkgs/id/e2e/tests/editor-features.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1137,7 +1137,9 @@ test.describe("Image Upload", () => {
await waitForEditorReady(page);

// Assert an <img> tag is visible inside the ProseMirror editor with the correct src
const img = page.locator("#editor .ProseMirror img");
// Scope to img.pm-image: a bare "img" locator also matches ProseMirror's internal
// <img class="ProseMirror-separator">, which fails toBeVisible strict mode (#1228)
const img = page.locator("#editor .ProseMirror img.pm-image");
await expect(img).toBeVisible({ timeout: 15_000 });
const src = await img.getAttribute("src");
expect(src).toContain(uploadResult.url);
Expand Down Expand Up @@ -1607,10 +1609,12 @@ test.describe("Image Alt-Text", () => {
data: { name: mdName },
});
expect(newResp.ok()).toBeTruthy();
const { hash } = (await newResp.json()) as { hash: string; name: string };

// Save with an image node that has alt text
// Save with an image node that has alt text (doc_id is required by SaveRequest, #1228)
const saveResp = await page.request.post(`${baseURL}/api/save`, {
data: {
doc_id: hash,
name: mdName,
doc: {
type: "doc",
Expand Down Expand Up @@ -1670,10 +1674,12 @@ test.describe("Image Resize", () => {
data: { name: mdName },
});
expect(newResp.ok()).toBeTruthy();
const { hash } = (await newResp.json()) as { hash: string; name: string };

// Save with an image node that has explicit dimensions
// Save with an image node that has explicit dimensions (doc_id is required by SaveRequest, #1228)
const saveResp = await page.request.post(`${baseURL}/api/save`, {
data: {
doc_id: hash,
name: mdName,
doc: {
type: "doc",
Expand Down
Loading