Skip to content

fix(id): complete integration VM suite - #1246

Merged
dezren39 merged 1 commit into
mainfrom
sweep/896-integration-timeout
Oct 28, 2026
Merged

dezren39 merged 1 commit into
mainfrom
sweep/896-integration-timeout

Conversation

@dezren39

@dezren39 dezren39 commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Follow-up to #905 / #896.

Problem

The stale serve/e2e assertions were fixed and their VM checks passed, but the full nixos-integration suite still hit the 20-minute global timeout in nightly run 40218257778. The test harness hides progress by default, making a long-running world test indistinguishable from a deadlock.

Solution

  • Allow the full two-worker cli_integration suite up to 60 minutes. The suite has roughly 134 tests, multiple world/server processes, and three-minute per-child deadlines; CI demonstrated that 20 minutes was still insufficient.
  • Run the test harness with --nocapture --format=terse so future CI failures identify the test currently running instead of appearing as a silent VM timeout.

Verification

  • git diff --check passed.
  • No Nix builds or VM tests were run locally, per the 7 GB memory sandbox rule.
  • The PR's CI and a manually dispatched full nightly run are the verification of record.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner October 27, 2026 04:19
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 39 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7885f52d-00d5-4a31-a703-6b3bbf78088b
Commits

Reviewing files that changed from the base of the PR and between ed8e591 and cc46ea3.

Files selected for processing: 1
  • pkgs/id/nix/tests/integration-test.nix
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T09:48:11.412887Z cc46ea3 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39
dezren39 force-pushed the sweep/896-integration-timeout branch from 6c48403 to cc46ea3 Compare October 28, 2026 09:46
@dezren39

Copy link
Copy Markdown
Member Author

🤖 Agent note · picked up

@dezren39

Copy link
Copy Markdown
Member Author

🤖 Agent note · parked

@dezren39

Copy link
Copy Markdown
Member Author

Shepherd result — verification nightly recorded

Manually dispatched verification run: id e2e nightly 40666995402 at this PR's head cc46ea3f — completed 2026-10-28T12:32Z with conclusion failure, but the failure is not this PR's change:

Per the fleet's standing merge rule (own checks green + change verified sound; unrelated CI failures noted, not blocking), this PR is being merged. The integration suite's clean nightly signal is tracked by #1666.

— queue worker (repo-worker-code), task 1775 / issue #1636

@dezren39
dezren39 merged commit c04a943 into main Oct 28, 2026
33 of 34 checks passed
@dezren39
dezren39 deleted the sweep/896-integration-timeout branch October 28, 2026 12:47
@dezren39 dezren39 removed the queue/queued Has a queued task in the Supabase agent queue label Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant