Repository navigation
fix(id): complete integration VM suite - #1246
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
6c48403 to
cc46ea3
Compare
|
🤖 Agent note · parked
|
Shepherd result — verification nightly recordedManually dispatched verification run: id e2e nightly 40666995402 at this PR's head
Per the fleet's standing merge rule (own checks green + change verified sound; unrelated CI failures noted, not blocking), this PR is being merged. The integration suite's clean nightly signal is tracked by #1666. — queue worker (repo-worker-code), task 1775 / issue #1636 |
Follow-up to #905 / #896.
Problem
The stale serve/e2e assertions were fixed and their VM checks passed, but the full
nixos-integrationsuite still hit the 20-minute global timeout in nightly run 40218257778. The test harness hides progress by default, making a long-running world test indistinguishable from a deadlock.Solution
cli_integrationsuite up to 60 minutes. The suite has roughly 134 tests, multiple world/server processes, and three-minute per-child deadlines; CI demonstrated that 20 minutes was still insufficient.--nocapture --format=terseso future CI failures identify the test currently running instead of appearing as a silent VM timeout.Verification
git diff --checkpassed.Need help on this PR? Tag
@codesmith-botwith what you need.