Repository navigation
fix(id): clear nightly pre-VM compile and formatter failures - #4696
Merged
Merged
Conversation
…r_ansi_diff visibility (#1372) - biome format --write: 18 web files (matches nightly web-fmt-check 18 errors) - world_ssh.rs: auth_publickey takes VerifiedPublicKey (russh 0.65 trait change; E0053) - id-core world_presentation.rs: render_ansi_diff pub(crate) -> pub (E0624, called from id crate)
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web-fmt-checkon the nightly head.auth_publickeysignature toVerifiedPublicKeyand exposeScreenSurface::render_ansi_diffto theidcrate (the reported E0053 and E0624 errors).maininto the preserved queue branch; other reported Rust compile errors (routes, references) are already corrected on main.Evidence
Nightly run 41488645351 on main
7297b5d354c8fdfa9dc1f226232e7b857af11b95failed before any VM boot. The run reported Magic Nix Cache HTTP 418 at 17:19:59Z, then E0053 (world_ssh.rs:308) and E0624 (world_ssh.rs:921); thenixos-test-driver-id-integrationfailure was dependency fallout, not a VM timeout. The original 20-minute timeout was already addressed by PR #1246 (globalTimeout = 3600). Cache follow-up is tracked in #774; its existing owner direction prefers removing Nix from Actions rather than adding another cache workaround.Verification
just web-fmt-check— pass.just check-shfmt— pass after formatting the two scripts.just just-recipes-checkandbash scripts/just-recipes-check-test.sh— pass.rustfmt --edition 2024 --checkon both changed Rust files — pass.cargo check --workspace --all-targets --features web,sshis being rerun after generating the ignoredweb/distassets; the first attempt stopped at the expected missing-assets error before source validation.cargo fmt --all -- --checkstill reports pre-existing drift in 41 Rust files on current main (the same nightly also failedcargo-fmt-check); this PR does not reformat that unrelated tree-wide set.nix flake checknot rerun locally.Refs #1372
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.