Skip to content

fix(openclaw): remove opencode-acp entry that cannot evaluate (#2509) - #2512

Merged
dezren39 merged 1 commit into
mainfrom
fix/openclaw-acp-entry-eval-2509
Oct 30, 2026
Merged

dezren39 merged 1 commit into
mainfrom
fix/openclaw-acp-entry-eval-2509

Conversation

@dezren39

@dezren39 dezren39 commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Removes the opencode-acp agent entry from home/openclaw/default.nix: as written it makes the entire NixOS configuration fail to evaluate, which has blocked every laptop switch since it merged (#2237).

Root cause is in the nix-openclaw generated schema, not in the entry's intent: an entry's runtime is typed as a oneOf of two submodules, and under the pinned nixpkgs the acp branch is unreachable. Full analysis and a 15-line minimal reproduction: #2509.

Verified: nix eval .#nixosConfigurations.amd.config.system.build.toplevel.drvPath succeeds with this change (fails without it).

The ACP capability itself (#1728: acp.enabled, allowedAgents, acpx plugin, wrappers) is untouched — OpenClaw can still spawn OpenCode over ACP from sessions. Restoring the standing ACP-runtime agent entry is tracked by #2256 and unblocks when the schema can express it (#2509).

Deployment chain context: this unblocks the #2220/#2250 switch (#2229).


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

The nix-openclaw generated schema makes the acp runtime branch of an agent entry unreachable (oneOf of submodules, pinned nixpkgs), so the entry fails the whole NixOS evaluation and blocks every switch. Analysis + minimal repro: #2509. Restore tracked by #2256. The ACP capability (acp.enabled, allowedAgents, acpx plugin) is unaffected.
@dezren39
dezren39 requested a review from a team as a code owner October 30, 2026 02:21
@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 19 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6637d752-984c-45bb-9942-3305f382dc98
Commits

Reviewing files that changed from the base of the PR and between 7d1b081 and 7ae9888.

Files selected for processing: 1
  • home/openclaw/default.nix
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T02:23:57.861206Z — PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39
dezren39 added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit a924c99 Oct 30, 2026
3 checks passed
@dezren39
dezren39 deleted the fix/openclaw-acp-entry-eval-2509 branch October 30, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant