Repository navigation
fix(openclaw): remove opencode-acp entry that cannot evaluate (#2509) - #2512
Conversation
The nix-openclaw generated schema makes the acp runtime branch of an agent entry unreachable (oneOf of submodules, pinned nixpkgs), so the entry fails the whole NixOS evaluation and blocks every switch. Analysis + minimal repro: #2509. Restore tracked by #2256. The ACP capability (acp.enabled, allowedAgents, acpx plugin) is unaffected.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 19 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Removes the
opencode-acpagent entry fromhome/openclaw/default.nix: as written it makes the entire NixOS configuration fail to evaluate, which has blocked every laptop switch since it merged (#2237).Root cause is in the nix-openclaw generated schema, not in the entry's intent: an entry's
runtimeis typed as aoneOfof two submodules, and under the pinned nixpkgs the acp branch is unreachable. Full analysis and a 15-line minimal reproduction: #2509.Verified:
nix eval .#nixosConfigurations.amd.config.system.build.toplevel.drvPathsucceeds with this change (fails without it).The ACP capability itself (#1728:
acp.enabled,allowedAgents, acpx plugin, wrappers) is untouched — OpenClaw can still spawn OpenCode over ACP from sessions. Restoring the standing ACP-runtime agent entry is tracked by #2256 and unblocks when the schema can express it (#2509).Deployment chain context: this unblocks the #2220/#2250 switch (#2229).
Need help on this PR? Tag
@codesmith-botwith what you need.