Skip to content

fix(flake): restore the neovim-src input that lib/default.nix inherits - #2599

Merged
dezren39 merged 1 commit into
mainfrom
fix/flake-neovim-src-input
Oct 30, 2026
Merged

dezren39 merged 1 commit into
mainfrom
fix/flake-neovim-src-input

Conversation

@dezren39

@dezren39 dezren39 commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

d1caeb4 (2026-10-29, "cleanup stale inputs and overrides") removed the neovim-src input declaration from flake.nix, but lib/default.nix still does inherit (inputs) neovim-src (from 008b74f) — so the amd system configuration no longer evaluates: attribute 'neovim-src' missing. That cleanup landed with nix eval skipped, so the break only surfaced at the next NixOS switch attempt (it is what just failed the deploy switch for #2220/#2250).

This restores the declaration exactly as it stood (github:neovim/neovim, flake = false) plus the neovim-nightly-overlay inputs.neovim-src.follows, and refreshes flake.lock (also pruning the gitignore nodes the same cleanup orphaned).

Verified: nix eval .#nixosConfigurations.amd.config.system.build.toplevel.drvPath succeeds on this branch.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

d1caeb4 (2026-10-29, build(flake): cleanup stale inputs and overrides) removed the neovim-src input declaration from flake.nix, reasoning that its follows declarations referred to missing elements — but lib/default.nix still does inherit (inputs) neovim-src (added by 008b74f), so evaluating the amd system configuration fails with: attribute neovim-src missing. That cleanup landed with nix eval skipped, so the break was invisible until the next switch attempt. This restores the declaration exactly as it stood (github:neovim/neovim, flake = false) plus the neovim-nightly-overlay follows, and refreshes flake.lock (which also prunes the gitignore nodes the same cleanup orphaned). Verified: nix eval .#nixosConfigurations.amd.config.system.build.toplevel.drvPath succeeds.
@dezren39
dezren39 requested a review from a team as a code owner October 30, 2026 06:28
@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b7d7ae23-6a10-4355-af74-92021bb33bae
Commits

Reviewing files that changed from the base of the PR and between 1f8ad59 and 7c688af.

Files ignored due to path filters: 1
  • flake.lock is excluded by !**/*.lock
Files selected for processing: 1
  • flake.nix
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T06:29:43.208976Z 7c688af PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39
dezren39 merged commit 4a548cf into main Oct 30, 2026
14 of 15 checks passed
@dezren39
dezren39 deleted the fix/flake-neovim-src-input branch October 30, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant