Skip to content

fix(muse-proxy): resolve contributor model ids in direct mode (#2753) - #2762

Merged
dezren39 merged 1 commit into
mainfrom
muse-direct-contributor
Oct 30, 2026
Merged

dezren39 merged 1 commit into
mainfrom
muse-direct-contributor

Conversation

@dezren39

@dezren39 dezren39 commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Phase 2 amendment for #2753 (Drew, 2026-10-30: "should use contributor and disable all other muse meta providers and replace with this") — the proxy half. The config half (contributor models in muse-direct, other Meta doors disabled, route retargets) follows in a separate PR.

What

resolveModelAndEffort in bin/muse-proxy.mjs now understands contributor ids:

  • muse-spark-1.3-contributor / muse-wonder-1.0-contributor resolve to their base model for lookup, then the resolved baseModel re-attaches -contributor, so direct mode sends the contributor id upstream on /v1/responses verbatim.
  • An effort suffix after the contributor part parses as the effort: muse-wonder-1.0-contributor-high → base muse-wonder-1.0-contributor, effort high, fullName muse-wonder-1.0-contributor-high.
  • A plain base-model request still sends the plain id — contributor is the caller's (config's) choice, never a proxy rewrite.

Test

New unit test (stub Meta API): contributor + effort-suffix parse, contributor with default effort, and the plain-id no-rewrite guard, asserting the exact upstream model/reasoning bodies. Full file on the laptop: 20/20 pass (19 prior + this one).


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner October 30, 2026 14:08
@dezren39
dezren39 merged commit 5ed8621 into main Oct 30, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T14:09:49.779942Z 65ae295 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a3652322-52b9-4dd1-8c47-d76031652564
Commits

Reviewing files that changed from the base of the PR and between c164993 and 65ae295.

Files selected for processing: 2
  • bin/muse-proxy.mjs
  • bin/muse-proxy.test.mjs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant