You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Test-only fix in pkgs/id/e2e/tests/editor-features.spec.ts: the "plain text file has no syntax highlighting" test now excludes spans inside collab-cursor decorations (.collab-cursor, .collab-cursor-bar) from its colored-span count.
Why
Probe task 1250's verdict on #1229: the single counted span was a collab-cursor-bar-segment decoration (styled background + text color, data-client-id/data-position attributes) rendered inside .collab-cursor — not a Shiki highlight leak. The .txt editor's paragraph contained no highlight spans. The exclusion is decoration-scoped: a genuine Shiki span anywhere else in the editor still counts, so the test keeps its teeth.
Queue task 4682 (repo-health-code-pilot), follow-up to probe task 1250.
Need help on this PR? Tag @codesmith-bot with what you need.
Summary by CodeRabbit
Tests
Updated editor syntax-highlighting checks to exclude collaboration cursor elements when counting colored text spans, while continuing to include styled text elsewhere in the editor. This makes the test results more accurately reflect syntax highlighting.
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.
No actionable comments were generated in the recent review.
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 10718e81-7fd7-40ee-bfdf-c1a5a6291ccf
Commits
Reviewing files that changed from the base of the PR and between 96d1349 and 74d1587.
Files selected for processing: 1
pkgs/id/e2e/tests/editor-features.spec.ts
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Walkthrough
The plain-text syntax-highlighting test now excludes colored spans inside collaborative cursor decorations when it counts spans in the editor.
developing-today/code#1229 — The issue describes a colored span counted by the plain-text editor test. This change excludes the collaborative cursor decoration spans from that count.
Merge Risk: Minimal · up to 74d15
The test adjustment avoids counting collaborative cursor decorations as syntax highlighting. No actionable merge-blocking risk is identified; merge after normal checks pass.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely identifies the main change: excluding collab-cursor spans from the plain-text highlight count test.
Linked Issues check
#1229 required identification of the colored span, a product-versus-decoration verdict, and a locator exclusion after the probe. The PR records the span as a collab-cursor-bar-segment inside `.colla…
Out of Scope Changes check
The whole-PR diff changes only pkgs/id/e2e/tests/editor-features.spec.ts. The added comments and the decoration-scoped exclusion directly support #1229. No unrelated product or editor changes are pr…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Linked Issues check
Explanation
#1229 required identification of the colored span, a product-versus-decoration verdict, and a locator exclusion after the probe. The PR records the span as a collab-cursor-bar-segment inside .collab-cursor, identifies its styling and attributes, and records that it is an editor decoration. The test excludes spans under .collab-cursor or .collab-cursor-bar while counting colored spans elsewhere. The change is limited to the required E2E test.
Full details: Out of Scope Changes check
Explanation
The whole-PR diff changes only pkgs/id/e2e/tests/editor-features.spec.ts. The added comments and the decoration-scoped exclusion directly support #1229. No unrelated product or editor changes are present.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
Biome (2.5.15)
pkgs/id/e2e/tests/editor-features.spec.ts
Biome could not lint this file: nested root configuration. Check the repository's Biome configuration and plugins.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Test-only fix in
pkgs/id/e2e/tests/editor-features.spec.ts: the "plain text file has no syntax highlighting" test now excludes spans inside collab-cursor decorations (.collab-cursor,.collab-cursor-bar) from its colored-span count.Why
Probe task 1250's verdict on #1229: the single counted span was a
collab-cursor-bar-segmentdecoration (styled background + text color,data-client-id/data-positionattributes) rendered inside.collab-cursor— not a Shiki highlight leak. The .txt editor's paragraph contained no highlight spans. The exclusion is decoration-scoped: a genuine Shiki span anywhere else in the editor still counts, so the test keeps its teeth.No product/editor code changes.
Closes #1229
Queue task 4682 (repo-health-code-pilot), follow-up to probe task 1250.
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit