Skip to content

test(id): exclude collab-cursor spans from plain-text highlight count (#1229) #3217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dezren39 merged 1 commit into from
Nov 1, 2026
Merged

test(id): exclude collab-cursor spans from plain-text highlight count (#1229) #3217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkgs/id/e2e/tests/editor-features.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,17 @@ test.describe("Syntax Highlighting", () => {
await page.waitForTimeout(2_000);

// .txt files use rich schema (not raw/code_block), so no Shiki spans
// Check that no syntax-colored spans exist
// Check that no syntax-colored spans exist. Collab-cursor decorations
// are not highlighting: the cursor bar segment carries a styled span
// (background + text color) inside .collab-cursor, and the probe on
// #1229 showed it is the one span this count used to pick up in a
// .txt editor. Exclude decoration spans only — a genuine Shiki span
// anywhere else in the editor still counts.
const coloredSpanCount = await editor.evaluate((el) => {
const spans = el.querySelectorAll("span[style]");
let count = 0;
for (const span of spans) {
if (span.closest(".collab-cursor, .collab-cursor-bar")) continue;
if ((span as HTMLElement).style.color) count++;
}
return count;
Expand Down