[dezren39]

Fixes #676

The close handler in bin/codex-proxy.mjs ignored the child's exit code and signal and did not track stderr, so a failed codex exec run was reported as a successful stop — HTTP 200 with empty content when nothing was produced, and HTTP 200 carrying truncated text when partial output preceded the failure. Stream mode likewise ended with a stop chunk + [DONE].

Fix (mirrors the muse-proxy #670/#672 pattern):

• Track a stderrTail (last 2000 chars) and any spawn error.
• On close, code !== 0 is a failure regardless of content produced: non-stream returns 500 with Codex execution failed: <last stderr line | spawn error | signal | exit code>; stream mode writes a data:-framed error event + data: [DONE] and no chunk claims finish_reason: stop.
• Successful (exit 0) runs are unchanged.

Tests: new bin/codex-proxy.test.mjs with a stub codex at $HOME/.local/bin/codex — success (both modes), FAILME (no output, exit 3), FAILPARTIAL (partial item.completed, exit 3), SIGKILLME (empty-stderr signal fallback). Local: 19/19 across codex-proxy + muse-proxy + proxy-port suites. Ablation: with the proxy fix reverted, exactly the 3 new failure tests fail (1 pass / 3 fail); restored, all pass.

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

Summary by CodeRabbit

• Bug Fixes
  • Failed Codex executions now return an error instead of appearing successful, including when partial output was produced.
  • Error details are included in responses when available, based on diagnostic output or the process exit status.
  • Streaming responses now include an error event and a completion marker; non-streaming responses return an HTTP 500 when possible.
• Tests
  • Added coverage for successful requests and execution failures, including partial output and forced termination.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-23T18:20:50.919458Z	a0a1b07	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 0c4aa262-581a-4602-ae90-7d0b61f2bf6c

📥 Commits

Reviewing files that changed from the base of the PR and between d8bfe7c and a0a1b07.

📒 Files selected for processing: 2

• bin/codex-proxy.mjs
• bin/codex-proxy.test.mjs

+---------------------------------------------+
| You shall not pass...without a code review! |
+---------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a0a1b07747

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Force the proxy test to select its stub

On the NixOS hosts configured by this repository, latestCli.codex is installed system-wide (nixos/environment/default.nix:407), while findCodexBinary() checks /run/current-system/sw/bin/codex before $HOME/.local/bin/codex (bin/codex-proxy.mjs:93-101). Therefore, changing HOME and writing this stub does not isolate the test: it invokes the real authenticated Codex binary, potentially making paid/network calls and causing these assertions to fail or hang. Add an injectable binary override or otherwise ensure the proxy selects the stub.

Useful? React with 👍 / 👎.