Repository navigation
docs(aggregator): success-only memoization contract + highlight latch fix (#3880) - #6796
Merged
Merged
Conversation
… fix (#3880) Phase 3 closing audit of design #3879 (gate cleared: #3732 + #3729 closed): - contract statement in pm-stack/aggregator/README.md matching the design wording - one-line pointer comments at the three memo sites (supabase clientPromise, alerts storePromise, push configurePromise) - pkgs/id/web highlight.ts: highlighterPromise now clears on rejection (success-only memoization) - the one confirmed same-shape latch found by the repo-wide inventory; success stays cached, in-flight sharing preserved
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 35 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3 (closing audit) of design #3879 — gate verified fresh before starting: Phase 1 #3732 CLOSED, Phase 2 #3729 CLOSED.
What lands here (part a + the one confirmed fix from part b)
pm-stack/aggregator/README.md("Lazy-initialization contract (Design: failure is not a result — one success-only memoization contract for lazy initializers (aggregator first) #3879)"), matching the design's wording: a lazy initializer memoizes success, never failure; clear on settle; every layer clears independently; failure values count as failure; in-flight sharing preserved; retry cost bounded by the secrets layer, not per-site TTLs.src/supabase.ts(clientPromise),src/alerts.ts(storePromise),src/push.ts(configurePromise).pkgs/id/web/src/highlight.tsfix:highlighterPromisewas the one confirmed same-shape latch in the repo-wide inventory — a rejectedcreateHighlighterCore(e.g. a transient chunk-load failure) latched for the page lifetime. It now clears the memo on rejection, exactly per the contract; success stays cached and concurrent callers still share the in-flight attempt. No other behaviour change.Parts b/c/d (recorded on the issues, not in this diff)
Tests: CI (fleet CI-first policy — no local builds). The highlight change is covered by the existing
highlight.test.ts/highlight-e2e.test.tssuites; the rest is docs/comments.Closes the implementation half of #3880; #3879 stays open for its own triage close-out.
🤖 Queue worker lane F (fallback mode, queue backend down — code#6619).