Repository navigation
test(id): execution tests for world logs / caps --ceiling / profile + world new scaffold compile (#5238) - #6808
Merged
developing-today[bot] merged 1 commit intoNov 7, 2026
Conversation
developing-today
Bot
requested review from
a team and
dezren39
as code owners
November 7, 2026 05:24
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
developing-today
Bot
deleted the
queue/fallback-5238-world-verb-execution-tests
branch
November 7, 2026 05:31
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Execution tests for the #5238 (9-8) verbs, in
pkgs/id/tests/cli_integration.rs(serve_tests), against a live counter world on a spawned host:test_world_logs_caps_ceiling_and_profile_execute— invites two guests, tails events withworld logswhile the other guest commits an input (asserts the event frame), sets the capability ceiling withworld caps --ceiling time.nowand reads it back in the caps report, and setsworld profile --wasm-fuel 424242with the admin token and reads it back as a guest. Every assertion is on host-reported state / read-back, so a silently no-op verb cannot pass.test_world_stats_executes_against_a_live_world— the stats counterpart (world_id, 64-char module hash, sequence ≥ 1, caps catalog, profile object). Committed#[ignore]d: it revealed a real bug — see below.test_world_new_scaffold_compiles— runsworld new, then compiles the scaffold'smain.rocwith the pinned roc against the repo platform (same invocation the scaffold'sbuild.shuses), asserting a wasm module comes out. Gated on the pinned roc + built platform host exactly like the existingtest_worlds_compile_roc_sources_on_the_fly.Revealed bug → #6802
id world statscannot succeed against a live host: it sendsinfo,caps,profile,metricsover one connection, but the host only servescaps/profileas first frames — the second query is refused withexpected a query frame. Per #5238's criterion 4 this is filed as its own issue (#6802, with fix options) instead of being fixed silently here; the stats test lands ignored naming #6802, ready to un-ignore in that fix.Verification
cargo test --test cli_integration -- test_world_logs_caps_ceiling_and_profile_execute test_world_new_scaffold_compiles test_world_stats_executes→ 2 passed, 1 ignored (stats).expected a query frame— the id world stats fails against a live host: "expected a query frame" (caps/profile frames refused mid-session) #6802 repro.targets/wasm32/host.wasm; the laptop's zig 0.17 cannot build the host —build.ziguses a removedOptimize.Debugfield — a pre-existing toolchain mismatch, same reason the existing Roc tests skip here). As supporting evidence,roc checkon realworld newoutput against the repo platform reports "No errors found". In CI, where the platform host is built, the test compiles for real.cargo check --test cli_integrationclean; the test file is rustfmt-clean.Verb-by-verb mapping is also posted on #796 and #5238.
Closes #5238
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.