Skip to content

test(id): execution tests for world logs / caps --ceiling / profile + world new scaffold compile (#5238) - #6808

Merged
developing-today[bot] merged 1 commit into
mainfrom
queue/fallback-5238-world-verb-execution-tests
Nov 7, 2026
Merged

developing-today[bot] merged 1 commit into
mainfrom
queue/fallback-5238-world-verb-execution-tests

Conversation

@developing-today

@developing-today developing-today Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

What

Execution tests for the #5238 (9-8) verbs, in pkgs/id/tests/cli_integration.rs (serve_tests), against a live counter world on a spawned host:

  • test_world_logs_caps_ceiling_and_profile_execute — invites two guests, tails events with world logs while the other guest commits an input (asserts the event frame), sets the capability ceiling with world caps --ceiling time.now and reads it back in the caps report, and sets world profile --wasm-fuel 424242 with the admin token and reads it back as a guest. Every assertion is on host-reported state / read-back, so a silently no-op verb cannot pass.
  • test_world_stats_executes_against_a_live_world — the stats counterpart (world_id, 64-char module hash, sequence ≥ 1, caps catalog, profile object). Committed #[ignore]d: it revealed a real bug — see below.
  • test_world_new_scaffold_compiles — runs world new, then compiles the scaffold's main.roc with the pinned roc against the repo platform (same invocation the scaffold's build.sh uses), asserting a wasm module comes out. Gated on the pinned roc + built platform host exactly like the existing test_worlds_compile_roc_sources_on_the_fly.

Revealed bug → #6802

id world stats cannot succeed against a live host: it sends info, caps, profile, metrics over one connection, but the host only serves caps/profile as first frames — the second query is refused with expected a query frame. Per #5238's criterion 4 this is filed as its own issue (#6802, with fix options) instead of being fixed silently here; the stats test lands ignored naming #6802, ready to un-ignore in that fix.

Verification

  • Laptop: cargo test --test cli_integration -- test_world_logs_caps_ceiling_and_profile_execute test_world_new_scaffold_compiles test_world_stats_executes → 2 passed, 1 ignored (stats).
  • The logs/caps/profile test failed at stats before the split, with the host's expected a query frame — the id world stats fails against a live host: "expected a query frame" (caps/profile frames refused mid-session) #6802 repro.
  • Scaffold test skips on the laptop (no targets/wasm32/host.wasm; the laptop's zig 0.17 cannot build the host — build.zig uses a removed Optimize.Debug field — a pre-existing toolchain mismatch, same reason the existing Roc tests skip here). As supporting evidence, roc check on real world new output against the repo platform reports "No errors found". In CI, where the platform host is built, the test compiles for real.
  • cargo check --test cli_integration clean; the test file is rustfmt-clean.

Verb-by-verb mapping is also posted on #796 and #5238.

Closes #5238


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

…ffold compile (#5238)

stats execution test included but #[ignore]d: it revealed #6802 (world stats mixes first-frame-only caps/profile queries into a query session and is refused by the host).
@developing-today
developing-today Bot requested review from a team and dezren39 as code owners November 7, 2026 05:24
@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 81b9de5d-8b86-4ef3-8b10-13e10627ea6b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@developing-today
developing-today Bot merged commit deee73e into main Nov 7, 2026
8 checks passed
@developing-today
developing-today Bot deleted the queue/fallback-5238-world-verb-execution-tests branch November 7, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

id phase-9/10 verification (split from #796): 9-8 CLI verb coverage — execution tests for stats/logs/caps/profile + world new scaffold compile

0 participants