Skip to content

chore: fit three comments to the four-line cap so lint passes on main - #24675

Merged
t3dotgg merged 1 commit into
mainfrom
fix/main-comment-cap
Oct 25, 2026
Merged

t3dotgg merged 1 commit into
mainfrom
fix/main-comment-cap

Conversation

@t3dotgg

@t3dotgg t3dotgg commented Oct 25, 2026

Copy link
Copy Markdown
Member

Lint fails on main right now, and that fails the required Check job on every open PR. The four-line comment cap merged after the deduped-bodies change, which added three longer comment blocks.

This trims those three blocks to four lines without changing what they say. Comment-only, no code changes. Repo-wide vp lint passes locally.

Created with Claude Opus 5.5 in Claude Code, running in T3 Code.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Oct 25, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 23363fa

Macroscope's review found this PR approvable — This PR only reformats existing comments to comply with the current four-line lint limit. No executable code, product defaults, schemas, or lint suppressions are changed, so there is no runtime impact.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 8f26ed7 and 23363fa.

Files selected for processing: 3
  • apps/server/src/orchestration-v2/WireProjection.ts
  • packages/contracts/src/orchestrationV2.ts
  • packages/shared/src/orchestrationV2DedupedBodies.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

Walkthrough

The documentation clarifies when per-subscription body deduplication occurs, which received-record ordering allows omission markers, and how clients restore marked fields. The summaries report no schema behavior changes.

Changes: Body Deduplication Documentation

Layer / File(s) Summary
Deduplication and omission-marker documentation
apps/server/src/orchestration-v2/WireProjection.ts, packages/contracts/src/orchestrationV2.ts, packages/shared/src/orchestrationV2DedupedBodies.ts
The comments clarify deduplication timing and record ordering, the conditions for omission markers, and client handling of marked fields. No schema behavior changes are described.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

  • pingdotgg/t3code#24647: Adds the body-deduplication implementation and wire-contract fields documented here.

Suggested reviewers: maria-rcks

Merge Risk: Minimal · up to 23363

The documentation-only changes are mergeable.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly identifies the main change: trimming three comments to satisfy the four-line lint limit.
Description check Passed The description explains the lint problem, the comment-only change, verification results, and the agent used. It does not include explicit section headings or scope and approval details, but it provid…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the lint problem, the comment-only change, verification results, and the agent used. It does not include explicit section headings or scope and approval details, but it provides the main required information for this focused change.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB −7 B (−0.1%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB −7 B (−0.6%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 20.9 KiB 20.9 KiB 0 B (0.0%) 29.3 KiB ✅
Codex Live turn messages 2 2 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB +7 B (+0.1%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB +7 B (+0.6%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.2 KiB 21.2 KiB 0 B (0.0%) 29.3 KiB ✅
Claude Live turn messages 2 2 0 (0.0%) 8 ✅

Baseline: e19fe08 · PR result: 23363fa · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@t3dotgg
t3dotgg merged commit 68d5b7a into main Oct 25, 2026
28 checks passed
@t3dotgg
t3dotgg deleted the fix/main-comment-cap branch October 25, 2026 02:34
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Oct 25, 2026
## What's Changed
* perf(mobile): highlight code with native @pierre/highlights instead of Shiki by @juliusmarminge in pingdotgg/t3code#24544
* fix(desktop): support Linux distro protocol launchers by @juliusmarminge in pingdotgg/t3code#24591
* fix(provider-acp): force-kill terminal commands that ignore SIGTERM by @juliusmarminge in pingdotgg/t3code#24596
* fix(grok): invoke leading picked skills through native commands by @juliusmarminge in pingdotgg/t3code#24605
* fix(server): long agent turns no longer load whole when a thread opens by @t3dotgg in pingdotgg/t3code#24589
* fix(server): analytics stop counting reconnects, retries, and dev servers by @t3dotgg in pingdotgg/t3code#24601
* fix(acp): idle agent errors fail their turns by @juliusmarminge in pingdotgg/t3code#24615
* fix(provider-acp): Grok monitors show as monitors in background work by @t3dotgg in pingdotgg/t3code#24609
* feat(server): devices on the same network reach background services over LAN by @t3dotgg in pingdotgg/t3code#24588
* fix(codex): bound pending requests after app-server stdout closes by @juliusmarminge in pingdotgg/t3code#24600
* fix(cursor): discover built-in skills in the composer by @juliusmarminge in pingdotgg/t3code#24595
* fix(server): retry provider event writes after brief SQLite locks by @juliusmarminge in pingdotgg/t3code#24571
* fix(server): settle inactive threads with persisted open PR links by @juliusmarminge in pingdotgg/t3code#24617
* feat(mobile): Settings is a workspace tab, and tabs never open on an empty detail by @juliusmarminge in pingdotgg/t3code#24524
* feat(mobile): the folded Duo opens search from a search tab below the tab bar by @juliusmarminge in pingdotgg/t3code#24360
* revert(mobile): take the folded Duo search tab back out for now by @juliusmarminge in pingdotgg/t3code#24626
* fix(web): preview images outside the workspace by @juliusmarminge in pingdotgg/t3code#24627
* fix(threads): Working holds only background work the agent waits on by @t3dotgg in pingdotgg/t3code#24610
* fix(web): switched threads and Scroll to end land on the real end by @t3dotgg in pingdotgg/t3code#24622
* fix(web): attach DNG originals as generic files by @juliusmarminge in pingdotgg/t3code#24625
* fix(server): surface failed runtime request answer delivery by @juliusmarminge in pingdotgg/t3code#24616
* fix(preview): report navigation timeout accurately by @Ethereal49 in pingdotgg/t3code#24356
* fix(web): give PR row metadata room below the title by @juliusmarminge in pingdotgg/t3code#24553
* fix(mobile): center floating status actions by @PixPMusic in pingdotgg/t3code#24526
* fix(mobile): the iPhone new-chat button sits beside the tab bar on iOS 26.6 by @wojas in pingdotgg/t3code#24492
* fix(web): signed-out T3 Connect shows a Sign in button by @t3dotgg in pingdotgg/t3code#24636
* perf(mobile): stop menu fault logging and whole-list re-renders on Home by @juliusmarminge in pingdotgg/t3code#24646
* fix(mobile): preserve syntax and navigation in large diffs by @juliusmarminge in pingdotgg/t3code#24276
* perf(shell): cold connects skip idle subagent threads, a third of the thread list by @t3dotgg in pingdotgg/t3code#24648
* feat: share a thread with a guest who watches live and sends messages you approve by @t3dotgg in pingdotgg/t3code#24104
* fix(antigravity): say when sign-in cannot reach Google by @t3dotgg in pingdotgg/t3code#24652
* fix: canonicalize git.cafe pull request links by @maria-rcks in pingdotgg/t3code#22634
* feat(mobile): manage labels, edit PRs and comments, react, and refresh checks live by @juliusmarminge in pingdotgg/t3code#24602
* perf(web): highlight code with @pierre/highlights instead of Shiki by @maria-rcks in pingdotgg/t3code#23178
* perf(server): thread opens and live events send each message body once by @t3dotgg in pingdotgg/t3code#24647
* refactor: halve code comments and cap comment blocks at four lines by @maria-rcks in pingdotgg/t3code#21514
* chore: fit three comments to the four-line cap so lint passes on main by @t3dotgg in pingdotgg/t3code#24675
* fix(claude): ENABLE_TOOL_SEARCH=auto no longer costs 10x cache writes per session by @t3dotgg in pingdotgg/t3code#24654
* perf(orchestration): thread snapshots send each long ID once by @t3dotgg in pingdotgg/t3code#24643
* fix(mobile): keep visible diff files highlighted by @juliusmarminge in pingdotgg/t3code#24682
* fix(mobile): Settings split view keeps its selection and its header matches the page by @juliusmarminge in pingdotgg/t3code#24644
* fix(mobile): every Duo header blurs under the vertical bar, from one place by @juliusmarminge in pingdotgg/t3code#24671
* feat(settings): follow-ups steer the running turn by default by @maria-rcks in pingdotgg/t3code#24718
* fix(mobile): Duo threads no longer open shifted left by @juliusmarminge in pingdotgg/t3code#24732
* fix(mobile): PR links open in the app the same way they do on web by @juliusmarminge in pingdotgg/t3code#24738
* feat(web): command palette search finds options inside submenus by @maria-rcks in pingdotgg/t3code#24709

## New Contributors
* @Ethereal49 made their first contribution in pingdotgg/t3code#24356
* @wojas made their first contribution in pingdotgg/t3code#24492

**Full Changelog**: pingdotgg/t3code@v0.1.3-nightly.20261024.3643...v0.1.3-nightly.20261025.3655

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.3-nightly.20261025.3655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant