[juliusmarminge]

Problem

AppRoot ran subscribeComposerDraftModelReconciliation from a mount-only useEffect. It is an app-lifetime store subscription with no React inputs, and AppRoot is rendered once from main.tsx, so the effect only tied a global install to a component lifetime.

Change

Install the subscription in startAppServices() (apps/web/src/appInit.tsx) right next to its sibling subscribeDraftThreadPromotion, which already takes the same registry and thread-shell atoms. Delete the effect and the useEffect import from AppRoot. Mobile already installs this exact subscription at app start (apps/mobile/src/App.tsx, appServiceDisposers), so web now matches.

What this improves

• Removes the last effect in AppRoot; all app-lifetime services now start in one place.
• No bug fix and no render change in the app.

Behavior changes

• The subscription now starts in startAppServices(), just before the first render, instead of after AppRoot mounts. It reconciles composer draft models the same way.
• apps/web/test/appScenarios.renders.tsx mounts <AppRoot> with its own router and never calls startAppServices(), so those render scenarios no longer run draft-model reconciliation (they already skip draft promotion and the other app services). Render baselines there may shift slightly.

Effects

• apps/web/src/AppRoot.tsx: 1 -> 0
• apps/web/src/appInit.tsx: 0 -> 0

Verification

• vp test run src/composerDraftStore.test.ts (covers the subscription itself): 74 passed
• vp run check:changed: format, lint, knip 1/2, knip 2/2, typecheck all pass

Model: Claude Opus 5.5, Claude Code harness.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at d1f9e96

Macroscope's review found this PR approvable — This is a small web initialization refactor that moves existing draft/model reconciliation from a component effect to the app-start service path. The reconciliation logic and inputs are unchanged; the localized runtime difference is that it is installed earlier and for the app lifetime.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: effect/split-a3-approot-draft-model-subscription
• File: .coderabbit.config.ts
• Commit: d1f9e96
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: b7a4b362-0706-4ff9-b9e6-d848a3963fee

Commits

Reviewing files that changed from the base of the PR and between dc84b09 and d1f9e96.

Files selected for processing: 2

• apps/web/src/AppRoot.tsx
• apps/web/src/appInit.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

Walkthrough

Composer-draft model reconciliation now starts in appInit with the app atom registry and thread and shell atoms. AppRoot no longer starts the subscription or imports its related atoms.

Changes: Composer draft reconciliation startup

Layer / File(s)	Summary
Move subscription setup to app initialization apps/web/src/appInit.tsx, apps/web/src/AppRoot.tsx	appInit starts composer-draft model reconciliation with the app atom registry and thread and shell atoms. AppRoot removes its subscription effect and related imports.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Possibly related issues

• [Bug]: Mobile: a model pick that was already delivered moves the thread back on a later message #24564: This change moves the subscription setup to appInit, but does not claim to fix the mobile race described in the issue.

Suggested labels: size:S

Suggested reviewers: none23, t3dotgg

Merge Risk: Minimal · up to d1f9e

The startup relocation is ready to merge with no established user-facing or operational risk.

Pre-merge checks: 3 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description clearly covers the problem, change, behavior effects, and verification. It does not provide the required Scope and approval information, such as a linked issue, explicit maintainer app…	Add the Scope and approval section. Link the triaged issue or maintainer approval, including the approval comment. If no prior issue or discussion applies, explain why this focused refactor qualifies for the exception.

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes moving draft model reconciliation to app startup.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description clearly covers the problem, change, behavior effects, and verification. It does not provide the required Scope and approval information, such as a linked issue, explicit maintainer approval, or an explanation of why this focused refactor qualifies without prior approval.

Resolution

Add the Scope and approval section. Link the triaged issue or maintainer approval, including the approval comment. If no prior issue or discussion applies, explain why this focused refactor qualifies for the exception.

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}