[juliusmarminge]

Problem

Each mobile ProjectFaviconImage with a URL committed twice on mount and on every request change (one per project row in sidebars, project lists and pickers). The first render had activeFaviconRequest === null, so it drew only the fallback; the layout effect then set state to mount the Image in a synchronous second render. The gate protected nothing: markProjectFaviconLoaded/Failed are reached only from expo-image's native onLoad/onError, which arrive after the same commit's layout effect has registered the request.

Change

• Remove the activeFaviconRequest state; render the Image whenever a request exists, and showImage = request !== null && status === "loaded".
• Keep the layout effect, now only registering the request with the module loader and returning its end function (external registration, no setState).
• New react-project test ProjectFavicon.test.tsx (added to the jsdom/React Compiler test list in apps/mobile/vite.config.ts).

What this improves

• Renders avoided: 2 -> 1 commits per favicon row on mount and on request change. Test mounts the favicon image in the first commit (Profiler phases) fails on main with ['mount', 'nested-update'] and passes here with ['mount'].
• Removes one useState and a react/set-state-in-effect suppression.

Behavior changes: none visible. The second commit ran before paint on main, so the favicon does not appear any earlier to the eye.

Effects

apps/mobile/src/components/ProjectFavicon.tsx: 1 -> 1 (layout effect kept as external registration; its setState removed).

Verification

• vp test run src/components/ProjectFavicon.test.tsx: pass; fails with main's ProjectFavicon.tsx swapped in.
• vp run check:changed: format, lint, knip 1/2, knip 2/2, typecheck (2 packages), test all pass.

Model: Claude Opus 5.5, Claude Code harness.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at 2219f29

Macroscope's review found this PR approvable — This is a focused mobile performance improvement that removes an unnecessary favicon state update, allowing the existing image to mount in the initial commit while preserving request-staleness checks and fallback behavior. The accompanying changes are test-only coverage and test-project registration.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: effect/split-a3-mobile-favicon-request-gate
• File: .coderabbit.config.ts
• Commit: 2219f29
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: 4198a577-4afd-4359-95cc-13251b74a0db

Commits

Reviewing files that changed from the base of the PR and between dc84b09 and 2219f29.

Files selected for processing: 3

• apps/mobile/src/components/ProjectFavicon.test.tsx
• apps/mobile/src/components/ProjectFavicon.tsx
• apps/mobile/vite.config.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

Walkthrough

ProjectFaviconImage no longer stores the active favicon request in React state. Image rendering uses the current request, and a new test checks rendering and profiler commits.

Changes: Favicon request rendering

Layer / File(s)	Summary
Request registration and rendering apps/mobile/src/components/ProjectFavicon.tsx, apps/mobile/src/components/ProjectFavicon.test.tsx, apps/mobile/vite.config.ts	The layout effect returns the loader cleanup directly. Image rendering depends on a non-null request. The added test checks that an image renders and that the profiler records one mount commit; the Vite config includes the test.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Possibly related PRs

• pingdotgg/t3code#25119: Adds a lint suppression for the state update that this PR removes.

Suggested reviewers: maria-rcks

Merge Risk: Minimal · up to 2219f

No actionable behavior change remains; the PR is ready to merge after normal checks.

Pre-merge checks: 3 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description clearly explains the problem, implementation, behavior impact, and verification. It omits the required Scope and approval section, including an issue, maintainer approval, or a rationa…	Add a Scope and approval section. Link the triaged issue or maintainer approval with the approval comment. If no prior issue or discussion exists, explain why this focused fix qualifies as an obvious bug exemption. Also state whether UI scr…

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main performance change: project favicons mount their image in one commit.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description clearly explains the problem, implementation, behavior impact, and verification. It omits the required Scope and approval section, including an issue, maintainer approval, or a rationale for the focused-fix exemption.

Resolution

Add a Scope and approval section. Link the triaged issue or maintainer approval with the approval comment. If no prior issue or discussion exists, explain why this focused fix qualifies as an obvious bug exemption. Also state whether UI screenshots are not applicable because the change has no visible behavior change, if required by repository policy.

Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}