Add new license Anti-Capitalist Software License #2362 - #2364

Merged

pombredanne merged 894 commits into

aboutcode-org:developfrom

sritasngh:anti-capitalist

Aug 25, 2021

sritasngh commented Jan 12, 2021 •

edited by pombredanne

Loading

Contributor

Signed-off-by: itssingh saritasingh.0425@gmail.com
Fixes #2362

Added new licenses ANTI-CAPITALIST SOFTWARE LICENSE v-1.0, v-1.1, v-1.2, v-1.3 and v-1.4

These added licenses are giving correct scan result.

Reviewed contribution guidelines
PR is descriptively titled 📑 and links the original issue above 🔗
Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
Run tests locally to check for errors.
Commits are in uniquely-named feature branch and has no merge conflicts 📁

pombredanne requested changes

View reviewed changes

pombredanne left a comment

Member

Thanks! I have a few nitpickings for your consideration before we can merge.

src/licensedcode/data/licenses/anti-capitalist-1.0.LICENSE Outdated

src/licensedcode/data/licenses/anti-capitalist-1.0.yml Outdated

src/licensedcode/data/licenses/anti-capitalist-1.1.LICENSE Outdated

src/licensedcode/data/licenses/anti-capitalist-1.2.LICENSE Outdated

src/licensedcode/data/licenses/anti-capitalist-1.3.LICENSE Outdated

src/licensedcode/data/licenses/anti-capitalist-1.3.LICENSE Outdated

src/licensedcode/data/licenses/anti-capitalist-1.2.yml Outdated

src/licensedcode/data/licenses/anti-capitalist-1.2.LICENSE Outdated

src/licensedcode/data/licenses/anti-capitalist-1.1.yml Outdated

src/licensedcode/data/licenses/anti-capitalist-1.1.LICENSE Outdated

sritasngh requested a review from pombredanne

March 13, 2021 14:44

pombredanne changed the title ~~Added new license Anti-Capitalist Software License #2362~~ Add new license Anti-Capitalist Software License #2362

pombredanne requested changes

View reviewed changes

pombredanne left a comment

Member

@itssingh Thank you! Almost there too here!

See the "ignorables"-related test failures in https://dev.azure.com/nexB/scancode-toolkit/_build/results?buildId=3262&view=logs&j=3c16b29b-eb82-5c7a-26ca-153f5e2ef8d4&t=525ae439-c19a-5d45-abf1-df81b3df2f93&l=43551 for your review.

sritasngh commented Mar 30, 2021 •

edited

Loading

Contributor Author

See the "ignorables"-related test failures

should I put url in notes: ?

pombredanne reviewed

View reviewed changes

pombredanne left a comment

Member

should I put url in notes:

no, you just need to add ignorable_* fields for URLs and emails

src/licensedcode/data/licenses/anti-capitalist-1.4.yml Outdated

src/licensedcode/data/licenses/anti-capitalist-1.4.yml Outdated

src/licensedcode/data/rules/anti_capitalist1.yml Outdated

src/licensedcode/data/rules/anti_capitalist1.yml Outdated

sritasngh requested a review from pombredanne

June 3, 2021 10:57

pombredanne requested changes

View reviewed changes

pombredanne left a comment

Member

Thank you! Please consider the few cleanups I suggested. Also feel free to squash all your commits in a single one.

src/licensedcode/data/licenses/anti-capitalist-1.4.yml Outdated

src/licensedcode/data/licenses/anti-capitalist-1.4.yml Outdated

src/licensedcode/data/rules/anti_capitalist1.yml Outdated

src/licensedcode/data/rules/anti_capitalist2.yml Outdated

src/licensedcode/data/rules/anti_capitalist3.yml Outdated

src/licensedcode/data/rules/anti_capitalist4.yml Outdated

sritasngh commented Jun 4, 2021

Contributor Author

consider the few cleanups I suggested

I left these #2364 (comment) as trailing line return #2364 (comment) as you previously suggested. Removed now :)

sritasngh requested a review from pombredanne

June 4, 2021 01:26

pombredanne and others added 20 commits

June 16, 2021 15:32


          Bump commoncode

729d5d6

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Merge pull request #2557 from nexB/bump-commoncode

ce169cf

Bump commoncode


          Merge pull request #2375 from abhi27-web/patch-1

5c7208a

Update CONTRIBUTING.rst

Authored-by: Abhigya Verma<abhigyaverma27@gmail.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Merge remote-tracking branch 'upstream/develop' into alpianon-patch-d…

16914ae

…ocumentnamespace


          Add CHANGELOG entry for SPDX format update

451f883

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Streamline SPDX formatting code #2344

219ac9f

Format code. Refactor common code between RDF and TV.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Update SPDX test expectatations #2344

6c7c024

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Use correct pytest setting for markers

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Clarify function to extract data from wheel name

d621379

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Merge remote-tracking branch 'pip2pi/master' into improve-thirdparty-…

f93558e

…utilities


          Add rules to improve debian-slim license detection

035d643

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>


          Regenerate tests after adding rules

9ae88d5

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>


          Add is_unknown flag for license class

a451a9c

Signed-off-by: akugarg <akanksha.garg2k@gmail.com>


          Add is_unknown flag to data files of unknown licenses

e62be42

Signed-off-by: akugarg <akanksha.garg2k@gmail.com>


          Ignore UUIDs in SPDX namespeca tests #2344

e6c3957

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Do not import deprecated debut module

d77fd7a

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Do not use deprecated execute2 function

af6a69f

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Do not use deprecated Type.object in jsonstreams

8b4b61b

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Merge pull request #2351 from alpianon/alpianon-patch-documentnamespace

bfb4110

added DocumentNamespace tag


          Add new generated keywords

98af887

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

pombredanne and others added 3 commits

August 6, 2021 15:37


          Merge pull request #2548 from akugarg/add_new_flag

0dd52df

Add new flag in License Data Model definition


          Update Contributing: Development setup-instructions

575c182

Some instructions were not (exactly) right, and some commands are now also highlighted properly.

Signed-off-by: Marcel Rettig <mapelpapel@gmail.com>


          Merge pull request #2631 from mapelpapel/update-contributing

b7d070f

Update Contributing: Development setup-instructions

Signed-off-by: Marcel Rettig <mapelpapel@gmail.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

sritasngh commented Aug 10, 2021

Contributor Author

@pombredanne Should I add notes for all the rules?

akugarg and others added 22 commits

August 10, 2021 23:29


          return referenced_filenames for licenses matches

a705382

Signed-off-by: akugarg <akanksha.garg2k@gmail.com>


          Update test cases upto expectations

ef8b217

Signed-off-by: akugarg <akanksha.garg2k@gmail.com>


          Merge pull request #2632 from akugarg/update_api

daeb709

Referenced_filenames should be returned by API function


          adds MIT detection rule 1055

1bab112

This provides a rule that matches MIT notices of form (note: indent for highlight):

  License

  This project is licensed under the terms of the MIT license.

Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com>


          apache-2.0_328.RULE: set minimum_coverage to 70

0632f33

This avoids Apache-2.0 "overriding" mit_349.RULE in cases like

  ## License

  This project is licensed under the terms of the MIT license.

Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com>


          Add emails and urls

75a744f

Add emails and urls in converted_infos. Add holders, authors, emails and
urls information in html template.

Signed-off-by: Sarita Singh <saritasingh.0425@gmail.com>
Co-authored-by: Avinal Kumar <avinal.xlvii@gmail.com>


          Add test for sample HTML template and update changelog

b7e35b7

Signed-off-by: Sarita Singh <saritasingh.0425@gmail.com>

Co-authored-by: Avinal Kumar <avinal.xlvii@gmail.com>


          Merge pull request #2539 from itssingh/html_temp

41d2d5b

Add emails and urls to HTML output


          Merge pull request #2636 from petergardfjall/issue-2635

6bf2fd9

Avoid misinterpreting MIT license notice as Apache-2.0, issue #2635


          Add new talis community license

50b4fcc

Signed-off-by: akugarg <akanksha.garg2k@gmail.com>


          Merge branch 'nexB:develop' into add_new_licenses

5ec3144


          Update test cases upto expectations

d954e40

Signed-off-by: akugarg <akanksha.garg2k@gmail.com>


          Add final report for GSoC'21

b51e281

Signed-off-by: akugarg <akanksha.garg2k@gmail.com>


          Merge pull request #2648 from akugarg/final_report

3be07db

Add final report for GSoC'21


          Merge branch 'develop' into 2110-dart-pubspec

0a4972e


          Add "--no-check-version" CLI option to scancode

23c8ef0

This version check causes problems when running in a firewalled environment (in my case, hanging for 30 seconds before timing out). This just adds a CLI option to skip it entirely.

Signed-off-by: Yunus Rahbar <yrahbar@fb.com>


          Merge pull request #2662 from yns88/no-check-version

f7b3a93

Add "--no-check-version" CLI option to scancode


          Merge pull request #2628 from nexB/2110-dart-pubspec

1cfe28f

Align tests for pubspec with latest code


          Merge pull request #2625 from akugarg/add_new_licenses

884f829

Add new licenses


          Merge remote-tracking branch 'itssingh/anti-capitalist' into develop

e18f389


          Remove trailing tab from license data files

c79c0ec

Somehow a tab had squeezed in

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>


          Do not use encoding with json.loads

2da1247

This is no longer supported in newest Python versions.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

pombredanne commented Aug 25, 2021

Member

FYI I merged the latest develop and fixed the tests, then pushed back to your branch

pombredanne approved these changes

View reviewed changes

pombredanne left a comment

Member

LGTM. Merging now at last. Thanks!

pombredanne merged commit 3a82423 into aboutcode-org:develop

sritasngh deleted the anti-capitalist branch

October 9, 2021 12:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet