Repository navigation
V0.14.0.x - #23
Merged
Merged
V0.14.0.x#23
Conversation
… be sent (#2783) * Introduce "qsendrecsigs" to indicate that plain recovered sigs should be sent Full nodes, including masternodes, will send this message automatically. Other node implementations (e.g. SPV) are usually not interested and would not send this message. * Use std::atomic<bool> instead of std::atomic_bool Not related to this PR, but a small enough change to include it here as well.
* Split out GetInstantSendLockHashByTxid from GetInstantSendLockByTxid * Filter ISLOCK messages based on provided filter
This still keeps the "libevent" logging category in place, but it now only logs >= EVENT_LOG_WARN severity.
* check matches for special transactions additional data * additional method to check matches for CKeyID * remove code duplication * unit tests for bloom filters for DIP2 txes * automatically update filters if special transaction matches * unit tests for filter updates * Error in comment Co-Authored-By: gladcow <sergey@dash.org> * use switch instead of if-chain * fix version check * remove code duplication * add negative tests in unit tests
* Bump MAX_OUTBOUND_MASTERNODE_CONNECTIONS to 250 on masternodes Masternodes now need to connect to much more other MNs due to the intra-quorum communication. 250 is a very conservative value loosely based on the absolute worst-case number of outgoing connections required, assuming that a MN manages to become part of all 24 active LLMQs. * Fix infinite loop in CConnman::Interrupt * Move out conditional calc into it's own variable Co-Authored-By: codablock <ablock84@gmail.com>
…tions (#2796) * Fix warning about size_t to int conversion * Fix loop in CLLMQUtils::GetQuorumConnections to add at least 2 connections When reaching very small quorum sizes, the current algorithm results in only a single connection to be added. This would be fine usually, but is an issue when this connection fails. We should always have at least one backup connection. This fixes simple PoSe test failures where the quorum size gets down to 4 with one of the 4 members being down. If other nodes are unlucky to connect to this node, they fail as well even though 3 members in a quorum should work fine. * Update src/llmq/quorums_utils.cpp Co-Authored-By: codablock <ablock84@gmail.com>
* Manually pull builder base image and let travis retry it on failure * Split base package installation in Dockerfile.builder into multiple RUN lines This allows better local cache usage on failure and retry. * Use travis_retry for docker build
…h late headers (#2793) * Also update bestChainLockWithKnownBlock in AcceptedBlockHeader * Implement BIP9 style DIP8 deployment * Fix ChainLocks tests * Apply suggestions from code review Co-Authored-By: codablock <ablock84@gmail.com>
…category (#2792) * Add missing log categories to help message and combined "dash" category * Sort alphabetically
* Sort evo/* source files in Makefile.am * Keep track of proRegTxHash in CConnman::masternodeQuorumNodes map We will later need the proRegTxHash * Fix serialization of std::tuple with const rvalue elements Having serialization and deserialization in the same specialized template results in compilation failures due to the "if(for_read)" branch. * Implement MNAUTH message This allows masternodes to authenticate themself. * Protect fresh incoming connections for a second from eviction Give fresh connections some time to do the VERSION/VERACK handshake and an optional MNAUTH when it's a masternode. When an MNAUTH happened, the incoming connection is then forever protected against eviction. If a timeout of 1 second occurs or the first message after VERACK is not MNAUTH, the node is not protected anymore and becomes eligable for eviction. * Avoid connecting to masternodes if an incoming connection is from the same one Now that incoming connections from MNs authenticate them self, we can avoid connecting to the same MNs through intra-quorum connections. * Apply review suggestions
No real reason to ignore this message. It might become useful in the future.
…UTH peers (#2798) * Pass CNode* to IsMasternodeQuorumNode and let it also check verifiedProRegTxHash This makes IsMasternodeQuorumNode return true on incoming peer connections as well. * Let GetMasternodeQuorumNodes also take verifiedProRegTxHash into account This makes it return NodeIds for incoming peer connections as well. * Remove AddParticipatingNode and the need for it This was needed in the past when we were unable to identify incoming connections from other quorum members. Now that we have MNAUTH, we can easily identify all connected members. * Don't track interestedIn quorums in CSigSharesNodeState anymore Same as with the previous commit, we're now able to easily identify which nodes to announce sig shares to. * Remove unused CConnman::GetMasternodeQuorumAddresses
…2799) * Use llmq-sig log category for CSigSharesManager * Use llmq-dkg log category for DKG related logging
* Prepare Dash-related stuff before starting ThreadImport * Ensure activeMasternodeManager is not null in ThreadImport when DIP3 is active and we are running in masternode mode
Replace it with regular "governance" category limited LogPrint-s where it makes sense.
* fix typo * align `=`s * fix warniing
…2804) * Reset local/static cache in LogAcceptCategory when categories change Without this, it is always required to first set debug to 0, wait a few seconds (until LogAcceptCategory is called by all affected threads) and then call "debug somecategory". Otherwise "ptrCategory" never gets updated. This PR also stores a cache counter locally and globally and updates "ptrCategory" when the counters do not match. * Lock cs_args in LogAcceptCategory
* Fix potential deadlock in LoadWallet() ``` POTENTIAL DEADLOCK DETECTED Previous lock order was: (1) cs_main wallet/wallet.cpp:3881 (2) cs_wallet wallet/wallet.cpp:3881 Current lock order is: (2) pwallet->cs_wallet wallet/walletdb.cpp:589 (1) cs_main wallet/wallet.cpp:1252 ``` * Add comment in CWallet::MarkConflicted re new cs_main lock in CWalletDB::LoadWallet()
* Fix qt tests and run them when compiling with DDEBUG_LOCKORDER flag * Drop "NO_QT=1"
Ignoring the same issue for legacy IS because it's going to be removed later.
* Update "debug" rpc help text * add missing "qt" category * add a note about non-matching categories
- Move "confirmations" to match actual RPC output order
* Drop all kind of invalid votes from all types of gobjects Currently we only do so for proposal "funding" votes which looks incomplete. * Apply review suggestions
* Always check for expired queues on masternodes * Check if a queue is too old or too far into the future Instead of only checking that it's to old * Check that no masternode can spam us with dsqs regardless of dsq readiness
* Fix cache usage in SelectCoinsGroupedByAddresses * Reset cache flags in SelectCoinsGroupedByAddresses when a block is (dis)connected * MakeCollateralAmounts should call SelectCoinsGroupedByAddresses with a limited number of inputs
) a0daea4 [build] depends macOS: point --sysroot to SDK (Sjors Provoost) Pull request description: Fixes errors like `fatal error: 'unistd.h' file not found` when building depends on macOS. Replaces bitcoin#14352 (which doesn't work on Catalina). ACKs for top commit: jonasschnelli: utACK a0daea4 Tree-SHA512: 995b1e1e84e635b32d1d4038bc63730c94a7c318b7240f6d62825977e5c97fe52c5aa5a0f39070beb0df8271dd294b36d6b5cf7f09ad07494fb15d5bd4d77f68
This avoids timeouts on parts of the network
* Update activemn if protx info changed * Add `==` and `!=` operators to CDeterministicMNState * Only re-init active MN if its IP changed, changes to payout, voting etc. can be done without it * Test `masternode status` updates * Don't track mnListEntry anymore and instead get the DMN on demand * Revert "Add `==` and `!=` operators to CDeterministicMNState" This reverts commit fba4687.
22f816e net: Improve and document SOCKS code (Wladimir J. van der Laan) Pull request description: Make the SOCKS code more consistent, and document the constants used. Tree-SHA512: 1bb04fcd6aacb6bfd2c54989d8298c892036466a895efb88be36fbace041af67c964ae0f5fb76c96f813f20a040109de4e0aac49a20844640e4d7633fcb22f25
"subtractFeeFromOutputs" is applied to the ordering of the input transaction and after that BIP69 sorting is performed. This causes flakiness in tests.
[v0.14.0.x] Backport pending PRs from develop into v14
* Bump version to 0.14.0.4 * Run gen-manpages.sh to update versions * Prepare release notes for 0.14.0.4 * Add first draft of "Notable Changes" * Handle review comments
… set on a peer (#3225) c4af738 Fix ignoring tx data requests when fPauseSend is set on a peer (Matt Corallo) Pull request description: This resolves a bug introduced in 66aa1d5 where, if when responding to a series of transaction requests in a getdata we hit the send buffer limit and set fPauseSend, we will skip one transaction per call to ProcessGetData. Bug found by Cory Fields (@theuni). Probably worth slipping into 0.16 :/. Tree-SHA512: a9313cef8ac6da31eb099c9925c8401a638220cf7bc9b7b7b83151ecae4b02630f2db45ef6668302b9bb0f38571afbd764993427f1ec9e4d74d9a3be6647d299
…/start_masternodes (#3221) * Tests: Connect to the control node only in start_masternodes Masternodes should take care of intra-quorum connections themselves * Reconnect non-masternodes back to the control node
But slightly modified so that they work with wait_until which does not assert in v0.14.0.x
* Implement re-signing of InstantSend inputs when TXs come in via blocks * Use GetAdjustedTime instead of GetTimeMillis in CSigSharesManager This allows use of mocktime in tests. * Expose verifiedProRegTxHash in getpeerinfo and implement wait_for_mnauth * Allow to wait for IS and CL to NOT happen * Bump timeout for wait_for_instantlock * Implement tests for retroactive signing of IS and CLs * Add wait_for_tx function to DashTestFramework * Add -whitelist=127.0.0.1 to node0 * Use node3 for isolated block generation * Don't test for non-receival of TXs on node4/node5
Mostly related to wait_until not asserting in 0.14.0.x
[v0.14.0.x] Backport pending PRs
* Bump version to 0.14.0.5 * Copy 0.14.0.4 release notes and prepare 0.14.0.5 release notes * Run gen-manpages.sh
…cksHandler despite node restarts (#3230)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 14 Update
DIP0004 - Coinbase Payload v2
DIP0008 - ChainLocks
DIP0010 - LLMQ-based InstantSend