fix(web): urgent and warning notices no longer hide behind activity banners

[mxdhavgautam]

An active goal took the composer’s front banner slot, hiding usage-limit recovery controls behind the peek. Urgent, error, and warning banners now rank ahead of activity, so the usage-limit banner is the single attached front banner and the goal stays behind “Show other notices”. Ordinary notices remain last, with stable ordering within each rank.

The implementation keeps main’s single front item and one collapsible stack. The production diff changes only the two priority conditions; no separate pinned region or activity-layout changes remain.

Maintainer takeover of #18919, with thanks to @mxdhavgautam for the reproduction and original fix. Contributor commits are preserved, with current main merged and the single-banner correction added on top.

Validation

• Exactly two Chromium component tests before → after. The original notice-details test is unchanged. The regression puts activity before the urgent limit in its input, checks exactly one visible banner with the limit attached, expands to reveal the goal, and uses Escape to return to one banner.
• The rewritten regression rejects the prior two-visible-banner implementation. Both final tests pass; targeted React Compiler coverage, scoped lint/format, web package typecheck, and diff checks pass.
• Fresh independent Opus and Sol full-diff reviews after the single-banner rebuild found no issues. The published diff matches the reviewed bytes.
• Running app: one usage-limit banner while collapsed; goal visible only after expansion; Escape restores one banner. The floating activity row fits correctly, so its existing inline layout is unchanged.

Before — main attaches the goal and hides recovery controls:

After — exactly one usage-limit banner, activity behind the peek:

Expanded — activity appears when requested:

Short recording: expand activity, then Escape back to one banner

Headless Linux proof uses an isolated synthetic usage-limit and active-goal fixture, with the same browser-only fallback font on both sides because this VM’s Chromium system fonts rendered blank. No production font changes. Real-provider limits and recovery mutations, remote/tunnel sessions, macOS, Windows, iOS, Android, and Electron desktop were not exercised.

Models/harness: tests — Codex gpt-6-astra; implementation — Codex gpt-6.1-sol; reviews — Claude claude-opus-5-5 and Codex gpt-6-sol; integration and publishing — Codex in T3 Code.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-13T04:09:44.679452Z	5bd1acb	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[macroscopeapp]

Approvability

Verdict: Approved at b448dc8

Macroscope's review found this PR approvable — This is a small, self-contained UI bug fix that reorders existing composer banners so urgent and warning notices remain attached and actionable. The focused browser regression test verifies the collapsed and expanded stack behavior, with no schema, infrastructure, or static-analysis changes.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 5bd1acb

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

• Last reviewed commit: 97d0401
• Latest commit, not reviewed: b448dc8

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: 1e84b377-8886-4023-821a-9d344bcf77d4

📥 Commits

Reviewing files that changed from the base of the PR and between 393ca71 and 97d0401.

📒 Files selected for processing: 2

• apps/web/src/components/chat/ComposerBannerStack.browser.test.tsx
• apps/web/src/components/chat/ComposerBannerStack.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The composer banner stack now keeps priority-1 notices visible above collapsible notices. Its collapsed peek and expanded list use only collapsible notices. A browser test checks the displayed notice order and peek contents.

Changes: Composer banner visibility

Layer / File(s)	Summary
Partition notices by priority apps/web/src/components/chat/ComposerBannerStack.tsx	Notices are ordered by priority and separated into pinned and collapsible groups. The stack closes when no collapsible notices remain.
Render pinned and collapsible notices apps/web/src/components/chat/ComposerBannerStack.tsx, apps/web/src/components/chat/ComposerBannerStack.browser.test.tsx	A shared renderer handles stacked notices. The peek uses the first collapsible notice. The browser test checks notice order and confirms that only the ordinary info notice appears in the peek.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: bil0000

Merge Risk: ⚪ Minimal · up to 97d04

The test protects the reported banner-visibility behavior, and no merge-blocking issue remains after normal checks.

Pre-merge checks: 4

Check name	Status	Explanation
Linked Issues check		The change satisfies [#18918]. bannerPriority ranks priority: "urgent" as the second tier, and it also ranks warning and error variants in that tier. pinnedItems renders that tier above the …
Out of Scope Changes check		The supplied change summary limits the implementation to ComposerBannerStack.tsx and its browser test. The warning and error handling supports the same stack-visibility defect and the related duplic…
Title check		The title clearly and concisely describes the main fix: urgent and warning notices remain visible instead of hiding behind activity banners.
Description check		The description is detailed and covers the problem, implementation, scope, linked maintainer takeover, validation results, screenshots, recording, limitations, and agent details. It does not use the t…

Full details: Linked Issues check

Explanation

The change satisfies [#18918]. bannerPriority ranks priority: "urgent" as the second tier, and it also ranks warning and error variants in that tier. pinnedItems renders that tier above the attached front item. The shared renderer preserves the usage-limit actions. The browser test verifies that urgent, warning, and error notices remain displayed while an activity notice is attached, and that only the ordinary notice remains in the collapsed group.

Full details: Out of Scope Changes check

Explanation

The supplied change summary limits the implementation to ComposerBannerStack.tsx and its browser test. The warning and error handling supports the same stack-visibility defect and the related duplicate scenario. The change preserves item ordering, activity attachment, and collapsed behavior for ordinary notices. No unrelated component, mobile rendering, copy, or default behavior is changed.

Full details: Description check

Explanation

The description is detailed and covers the problem, implementation, scope, linked maintainer takeover, validation results, screenshots, recording, limitations, and agent details. It does not use the template headings exactly, and the approval context could be more explicit, but the required information is substantially present.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[mxdhavgautam]

Note

🤖 Claude Opus 5.5 responding on behalf of Madhav

I rebased this onto current main (339179f) and checked it again in a dev build. The bug is still there on main. With six subagents running and the usage limit hit, the "Usage limit reached" banner collapses into a thin line behind "Waiting on 6 subagents". Cancel auto-resume and Snooze until reset stay hidden until you hover that line.

Main at 339179f:

This branch, rebased on 339179f:

On the rebased branch, ComposerBannerStack.test.tsx passes and the web typecheck is clean.

Dismissing prior approval to re-evaluate daffda2

[mxdhavgautam]

Note

🤖 Claude Opus 5.5 responding on behalf of Madhav

I extended this to cover #19455. Before, only urgent notices stayed expanded, so a plain warning like the reconnecting banner still collapsed behind an activity banner such as an active goal. Now every notice the stack already ranks in the urgent, warning and error tier stays expanded above the activity banner. Info and default notices still collapse behind the peek.

Main at 339179f, with an active goal and the backend stopped. The usage limit and reconnecting banners are both in the thin line above the goal:

This branch, same state:

The stack test now includes a warning and an error notice. It fails on main and passes here. I updated the title and description to match.

Dismissing prior approval to re-evaluate 393ca71

Dismissing prior approval to re-evaluate 42af01d

[mxdhavgautam]

Note

🤖 Claude Opus 5.5 responding on behalf of Madhav

Rebased onto main at b78296a. There were two conflicts, both in ComposerBannerStack.tsx. The fix itself works the same as before.

• perf(web): the composer banner stack compiles with the React Compiler #20582 replaced the useEffect that closes the expanded stack with a check during render, so the file compiles with the React Compiler. This PR had changed that effect's condition from "fewer than two banners" to "no notices left to collapse", because pinned notices no longer sit in the collapsed stack. The resolved code keeps main's render-time check and uses this PR's condition.
• refactor: prune narration and history comments #19559 deleted the "Activity stays attached" comment above the sort. This PR had moved that line, so the resolved code leaves the comment out, as main intended.

The one-line layout for activity banners from #20194 merged without a conflict and is unchanged.

On the new head (42af01d), the banner stack tests, the React Compiler test, the web typecheck, vp check and the web build all pass.

Dismissing prior approval to re-evaluate 97d0401

[mxdhavgautam]

Note

🤖 Claude Opus 5.5 responding on behalf of Madhav

Rebased onto main at d5b7095. The only conflict came from #20870, which moved the chat component tests into a real browser and deleted ComposerBannerStack.test.tsx. This PR had added its test to that file.

The test now lives in ComposerBannerStack.browser.test.tsx, next to the existing notice details test. It renders into a real page and reads the banner titles from it. It checks the same two things as before: the order of the banners, and that only the ordinary notice sits in the collapsed "Other notices" group. It fails against the component on main and passes with this change.

ComposerBannerStack.tsx merged without a conflict this time. On the new head (97d0401), the browser test, the React Compiler coverage test, the web typecheck, lint on the changed files and the web build all pass. The testing line in the description now names the new file.

[juliusmarminge]

Taking over this one as maintainer for batch web-misc-04. I will preserve your commits, merge current main, simplify the tests and implementation where useful, and run independent reviews. Thanks @mxdhavgautam for the reproduction and focused fix.

Dismissing prior approval to re-evaluate bb2e112

[mxdhavgautam]

Thanks for taking this over, Julius. Glad I could help, and I'm looking forward to seeing it ship.

Dismissing prior approval to re-evaluate b448dc8