[domvox]

The ManagedTunnelLimits test fails in a checkout whose path contains a space. URL.pathname leaves the path percent encoded, so FileSystem.readDirectory receives %20 and fails with ENOENT before it can apply the migrations.

Use the existing Effect Path service to convert the file URL to a filesystem path. NodeServices.layer already provides it. This changes only the test setup in ManagedTunnelLimits.test.ts, +5/-1.

This is related to #29587, but does not close that web-build issue. Open PR #27648 changes apps/web/vite.config.ts and does not cover this relay test. This focused fix qualifies for the CONTRIBUTING exception for a very small, obvious bug.

Validation on openSUSE, Node 26.12.1, pnpm 12.14.0, Vite+ 1.4.0, Effect 4.1.2, in the same checkout path containing a space:

• Baseline: the focused test fails with ENOENT for the percent-encoded migrations path; the whole file has 1 failed and 6 passed.
• After the fix: the focused test passes; all 7 tests in ManagedTunnelLimits.test.ts pass.
• Relay typecheck, scoped lint, and formatting check pass.
• Independent Codex Sol 6.1 High review found no code issues and confirmed the new test evidence satisfies the previous conditional review.

Run from infra/relay:

vp test run --config ../../vite.config.ts --dir . src/environments/ManagedTunnelLimits.test.ts
pnpm run typecheck

Run from the repository root:

vp lint --report-unused-disable-directives infra/relay/src/environments/ManagedTunnelLimits.test.ts
vp fmt --check infra/relay/src/environments/ManagedTunnelLimits.test.ts

Implementation: Claude Opus 5.5 High through Claude Code in Orca. Independent review: GPT-6.1-Sol High through Codex CLI in Orca.

[macroscopeapp]

Approvability

Verdict: Approved at a406723

Macroscope's review found this PR approvable — The change is confined to ignored paths and is described as fixing migration-path handling in relay tests for checkouts containing spaces. No material production impact is indicated.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The migration test now resolves the PostgreSQL migrations directory through the Path.Path service and fromFileUrl instead of using URL.pathname.

Changes: Migration Path Resolution

Layer / File(s)	Summary
Resolve the migrations directory infra/relay/src/environments/ManagedTunnelLimits.test.ts	The test imports Path and uses Path.Path with fromFileUrl to resolve the migrations directory.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Low

Possibly related PRs

• pingdotgg/t3code#26320: Added the migration integration test that this change updates to resolve paths with Path.fromFileUrl.

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · up to a4067

The migration test now supports checkout paths containing spaces and is ready to merge.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title is concise, specific, and accurately describes the fix for migration paths containing spaces.
Description check		The description explains the problem, implementation, scope exception, related issues, validation environment, test results, and commands used. It provides the required information, although it does n…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the problem, implementation, scope exception, related issues, validation environment, test results, and commands used. It provides the required information, although it does not use the template headings explicitly.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

CodeRabbit Verify

• Run CodeRabbit Verify to test the changes in this pull request.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: cefb544
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 10d6e496-03f2-4ef8-be54-86bf678d871d

Commits

Reviewing files that changed from the base of the PR and between cefb544 and a406723.

Files selected for processing: 1

• infra/relay/src/environments/ManagedTunnelLimits.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

verified head a406723ad1d7c6d5dcf5965acca7ad7780e4c55f against main cefb544af3c98224874419198c0359b652ca3c94. no changes needed.

this pr changes only test setup, so no running client/provider path executes the changed lines. the direct regression proof ran on task-owned blacksmith workers with installed dependencies and a full checkout path containing a space:

• main: ManagedTunnelLimits.test.ts failed reading source%20spaced/infra/relay/migrations/postgres/ with ENOENT; six other tests passed.
• pr: all seven tests passed from the spaced path and again from the ordinary path. this exercises the real pglite migrations and allocation/backfill assertions.
• relay typecheck, scoped lint and formatting passed.

command from infra/relay:

vp test run --config ../../vite.config.ts --dir . src/environments/ManagedTunnelLimits.test.ts

on the linux boat vm, started main and then the exact pr head with vp run dev, one server at a time. created a real git repository at /home/user/relay verification and added it through the app cli, without seeded data. real codex gpt-6.1-sol turns on both servers ran pwd and git status --short and reported the correct directory and clean worktree. on the pr, playwright with /usr/bin/google-chrome opened the thread, typed a follow-up, and pressed enter; codex ran git rev-parse --is-inside-work-tree and the web client displayed SPACED_REPO_OK. these are separate app smoke checks, not proof that the test setup runs in production.

command transcript

Not verified

native desktop, ios/android clients, macos/windows filesystem handling, and the external managed relay service were not exercised. no production behavior changes in this diff.