Repository navigation
revert(web): working threads stay in the Working shelf when their environment disconnects - #31269
Merged
Merged
Conversation
…ironment disconnects This reverts commit 033a753 (#26195). A thread that says it is working belongs in the Working shelf. Gating the shelf on connection and shell-sync state moved still-running threads on a remote environment back into the main list after a disconnect, while their rows kept showing "Working". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Working threads now stay in the Working shelf when their environment disconnects. This is a limited display-grouping change; existing settings and connection-based dragging safeguards remain unchanged. Notes:
You can add or adjust custom eligibility rules. Learn more. |
sandscooling
pushed a commit
to sandscooling/t3code
that referenced
this pull request
Nov 5, 2026
Sync 1105a: 31 upstream commits to 67eebac. Five conflicts, all additive (pingdotgg#24186 tab eviction in three preview files, pingdotgg#31269 revert in Sidebar.tsx, pingdotgg#24904 ghq clone layout in contracts settings). Fork code adjusted for upstream's new Effect rules (pingdotgg#31216, pingdotgg#31217) and a doubled import from the auto-merge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions Bot
added a commit
to Jefferson-Butler1/t3code
that referenced
this pull request
Nov 5, 2026
No patches were dropped. Upstream has no Inbox order setting of its own: nothing between 7f6f47b and the tag adds `InboxSortOrder` or anything like it. I ported `inbox-order.patch`. Only `apps/web/src/components/Sidebar.tsx` conflicted. Upstream pingdotgg#31269 reverted "working threads stay in the Working shelf when their environment disconnects". That removed the `disconnectedEnvironmentIds` field from `SidebarThreadPartitionInput`, the code in `useSidebarThreads` that computed it, and the places that passed it in and read it back out. The patch's lines sat next to that code, so all four hunks conflicted. I took upstream's version each time and put back only the patch's `inboxSortOrder` line: the interface field, the `useClientSettings((s) => s.sidebarInboxSortOrder)` read, the argument passed to `partitionSidebarThreads`, and the destructured value it sorts with. The disconnected-environment code stays removed. The other 15 files in the patch merged on their own, and the commit message is unchanged. Checks, all run on the fully patched tree: - `vp -C apps/web run typecheck`, `apps/desktop`, `apps/mobile` and `packages/contracts` typecheck: all pass. The only output is effect `schemaClassMissingBrand` suggestions, no errors. - `vp -C apps/desktop run build`: passes, 5 of 5 tasks. - `vp lint apps/web/src/components/ChatView.tsx scripts/build-desktop-artifact.ts`: passes. - `vp fmt --check` on all 16 files the patch touches: passes. - `vp -C apps/web test run src/components/Sidebar.logic.test.ts`: 81 of 81 pass. This is the test next to the file I edited. - `vp -C packages/client-runtime test run src/state/threadInbox.test.ts`: 23 of 23 pass. - Replay: the regenerated patch applies with plain `git am` (no `--3way`) to a fresh checkout of the tag. The resulting tree (7c52bea) is identical to the tree I checked.
github-actions Bot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Nov 5, 2026
**v0.1.8-nightly.20261105.4218** · 9 changes from 3 contributors - **Thread history.** Long threads retain their visible history when you open or reconnect to them. ### Plus 4 more bug fixes. <details> <summary>Full changelog</summary> ## What's Changed * revert(web): working threads stay in the Working shelf when their environment disconnects by @juliusmarminge in pingdotgg/t3code#31269 * refactor: Effect code reads env through HostProcess.Environment by @juliusmarminge in pingdotgg/t3code#31218 * refactor: Effect.try calls map failures to typed errors by @juliusmarminge in pingdotgg/t3code#31217 * fix(web): sidebar project filter rows line up and stay still on hover by @shivamhwp in pingdotgg/t3code#29639 * refactor: errors are Schema.TaggedError, not Data.TaggedError or native Error by @juliusmarminge in pingdotgg/t3code#31216 * fix(server): a stopped run no longer shrinks thread history to one row by @shivamhwp in pingdotgg/t3code#31266 * fix(server): refresh divergence after a merged branch ref changes by @Yash-Singh1 in pingdotgg/t3code#31342 * fix(mobile): one aligned notice for ChatGPT sharing limits by @shivamhwp in pingdotgg/t3code#31277 * fix(mobile): composer keeps the keyboard when a queued edit ends by @shivamhwp in pingdotgg/t3code#31317 **Full Changelog**: pingdotgg/t3code@v0.1.8-nightly.20261105.4205...v0.1.8-nightly.20261105.4218 </details> Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.8-nightly.20261105.4218
Pipyakas
pushed a commit
to Pipyakas/t3code
that referenced
this pull request
Nov 5, 2026
…ironment disconnects (pingdotgg#31269) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 3470164)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts https://git.cafe/pingdotgg/t3code/pulls/26195.
A thread that says it is working belongs in the Working shelf. https://git.cafe/pingdotgg/t3code/pulls/26195 gated the shelf on the environment being connected and its shell fully synced, so after a remote box dropped (an OOM on cups here) its still-running threads moved back into the main list while their rows kept saying "Working 39m". The sidebar ended up contradicting itself.
This restores the previous rule: the shelf follows the thread's working state only.
Model: Claude Opus 5.5 in Claude Code (T3 Code).
🤖 Generated with Claude Code