[juliusmarminge]

Problem

Mobile refreshed the selected thread's git status from a useEffect keyed on five primitives copied out of the selection, plus a useEffectEvent to avoid stale closures. Each consumer of useSelectedThreadGitActions ran its own copy, so two sheets showing the same checkout each fired a refresh.

Change

• packages/client-runtime: new createVcsStatusRevalidationAtomFamily. It makes one atom per environment and cwd that refreshes while mounted, but only through the connected atom it is given: once when that atom is true on mount, once per reconnect, and on an optional debounced wake signal. Every subscriber to the same checkout shares it, and the wake subscription and timer end with the last subscriber.
• Mobile: useSelectedThreadGitActions mounts the atom with useAtomMount. A new environmentConnectedAtom family supplies the connection flag, and setPendingConnectionError still reports refresh failures.
• Removed the .test.tsx render-loop harness that tested the old effect. The new family test covers the behavior instead.

Behavior change: opening a git sheet no longer refreshes on its own

Before, every useSelectedThreadGitActions mount fired a quiet refresh, so opening the Git overview, branches, commit, confirm, or review sheet triggered one. Those sheets are native-stack screens above ThreadRouteScreen, which stays mounted and holds the same (environment, cwd) atom. The atom is already live, so opening a sheet adds a subscriber and does not refresh again. This is fine. The route already refreshed on selection and on every reconnect. The sheets read the live subscribeVcsStatus stream, not a one-time snapshot. Every git mutation refreshes afterward, and the overview sheet keeps pull-to-refresh and its Refresh button. A sheet opened without the route underneath (a deep link) mounts the atom itself and refreshes as before.

What this improves

• Sync removed: the selection-driven refresh effect, which mirrored primitives into deps and needed useEffectEvent.
• Duplicate refreshes removed: consumers showing the same checkout now share one refresh per selection or reconnect (refreshes once per connection, shared by every subscriber, and again on reconnect).
• Tests in vcsStatusRevalidation.test.ts: waiting for the connection before the first refresh, debounced wake with teardown, and the idle target.

Effects

apps/mobile/src/state/use-selected-thread-git-actions.ts: 1 -> 0. Other touched files: 0 -> 0.

Effect report

From scripts/effect-report.ts --compare github/main (harness in #24980).

package	effects	syncEffects	noDeps	chained	renderRefWrites
apps/web/src	620	52	20	24	0
apps/mobile/src	398 → 397 (-1)	59	6	26	7
packages/client-runtime/src	0	0	0	0	0
total	1018 → 1017 (-1)	111	26	50	7

changed file	effects	syncEffects	noDeps	chained	renderRefWrites
apps/mobile/src/state/use-selected-thread-git-actions.ts	1 → 0 (-1)	0	0	0	0

Render scenarios: Mobile has no scenario harness yet; this change is mobile-only.

Verification

• vp test run packages/client-runtime/src/state/vcsStatusRevalidation.test.ts apps/mobile/src/state/use-selected-thread-git-actions.test.ts: 15 passed
• vp run check:changed: format, lint, knip, and typecheck (34 packages) pass. Tests: 2701/2702. The one failure was PullRequestCodeTab.browser.test.tsx ("Cannot verify that chromium request interception is active after 5s"), an environment flake in a file this PR does not touch. It passes on rerun.

Model: Claude Opus 5.5, Claude Code harness.

🤖 Generated with Claude Code

[github-actions]

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for ca1e467.

This comment will update automatically after the next completed run.

[macroscopeapp]

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This refactor changes mobile VCS refresh ownership and timing by introducing a shared connection-aware atom, alongside new lifecycle tests. It also adds an @effect-diagnostics globalTimers:off suppression, which requires human review under the configured policy.

Notes:

• All code in this push has already been reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: effect/split-F-vcs-revalidation
• File: .coderabbit.config.ts
• Commit: da58a63
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: 86bc0f33-6827-41f3-a785-f50bb909e97c

Commits

Reviewing files that changed from the base of the PR and between ca1e467 and da58a63.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: effect/split-F-vcs-revalidation
• File: .coderabbit.config.ts
• Commit: ca1e467
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: 9accf5d6-8531-4f29-91c6-83ac0146bd64

Commits

Reviewing files that changed from the base of the PR and between 582db9c and ca1e467.

Files selected for processing: 1

• scripts/effect-budget.json

Files with no reviewable changes: 1

• scripts/effect-budget.json

Limit details: You’ve used all 10 included reviews currently available.

Walkthrough

The client runtime adds a shared VCS status revalidation atom family. Mobile uses it to refresh status for the selected thread’s environment and working directory, with refresh errors reflected in pending connection state.

Changes: Mobile VCS status refresh

Layer / File(s)	Summary
Shared VCS status revalidation packages/client-runtime/src/state/vcsStatusRevalidation.ts, packages/client-runtime/src/state/vcsStatusRevalidation.test.ts, packages/client-runtime/src/state/vcs.ts	The new atom family shares refreshes by environment and working directory. It supports connection-triggered and wake-triggered refreshes, wake debouncing, and cleanup when subscribers unmount. Tests cover these behaviors, and vcs.ts re-exports the implementation.
Selected-thread refresh integration apps/mobile/src/state/use-remote-environment-registry.ts, apps/mobile/src/state/use-selected-thread-git-actions.ts, apps/mobile/src/state/use-selected-thread-git-actions.test.ts, apps/mobile/src/state/use-selected-thread-git-actions.test.tsx, scripts/effect-budget.json	Mobile adds an environment connection atom and mounts shared revalidation for a selected thread with a project and working directory. Refresh failures use a shared message helper. The test mocks change, the previous hook test is removed, and the effect-budget entry for the hook is deleted.

Priority: Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Refactor

Sequence Diagram(s)

sequenceDiagram
  participant Hook as useSelectedThreadGitActions
  participant Mount as useAtomMount
  participant Revalidation as selectedThreadStatusRevalidation
  participant Connection as environmentConnectedAtom
  participant Refresh as vcsEnvironment.refreshStatus
  participant ErrorState as setPendingConnectionError
  Hook->>Mount: Mount revalidation for selected environment and cwd
  Mount->>Revalidation: Subscribe to selected-thread status atom
  Revalidation->>Connection: Read connection state
  Connection-->>Revalidation: Connected state
  Revalidation->>Refresh: Refresh status when connected or woken
  Refresh-->>Revalidation: Return refresh result
  Revalidation->>ErrorState: Clear or set pending connection error

Loading

Possibly related issues

• pingdotgg/t3code#20254 — The shared refresh owner may address overlapping refresh work, but this change does not address slow Git commands or event-loop stalls.

Possibly related PRs

• pingdotgg/t3code#24827 — Changes the same Mobile Git-status hook and shared revalidation implementation.
• pingdotgg/t3code#24814 — Adds the shared client-runtime state facilities used by this change.
• pingdotgg/t3code#24824 — Mounts the same shared revalidation pattern for web Git actions.

Suggested reviewers: macroscopeapp

Merge Risk: Minimal · up to ca1e4

No issue with the selected change is established; it is mergeable after normal checks.

Pre-merge checks: 3 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description thoroughly covers the problem, change, behavior, and verification. It omits the required Scope and approval section, including issue or maintainer approval details or an exemption rati…	Add a Scope and approval section. Link the triaged issue or maintainer approval, or explain why this focused fix qualifies for an exemption.

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: one VCS status refresh owner per checkout.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description thoroughly covers the problem, change, behavior, and verification. It omits the required Scope and approval section, including issue or maintainer approval details or an exemption rationale.

Resolution

Add a Scope and approval section. Link the triaged issue or maintainer approval, or explain why this focused fix qualifies for an exemption.

Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}