[only21mil]

Problem

t3code/no-raw-resize-observer steers web code away from constructing ResizeObserver directly and toward observeResize, so layout derived from a resize commits in the same frame. Unlike most rules in oxlint-plugin-t3code/rules, it has no test file. A change to the rule that stopped reporting new window.ResizeObserver(...), or started flagging plain type references, would pass CI unnoticed.

Change

Adds no-raw-resize-observer.test.ts on the existing createOxlintRuleHarness, without changing the rule.

• Reported: direct new ResizeObserver(...), new window.ResizeObserver(...), and new globalThis["ResizeObserver"](...).
• Allowed: ResizeObserver and ResizeObserverEntry types, typeof ResizeObserver feature checks, and other observers such as MutationObserver.

Scope and approval

This is test-only coverage for an existing rule. It changes no product behavior, so it needs no prior approval. The rule's apps/web/src/** scope and its observeResize.ts exemption live in vite.config.ts and stay outside this suite. Nothing on screen changes, so there are no screenshots.

Verification

• vp test run --config ../vite.config.ts --dir . rules/no-raw-resize-observer.test.ts (from oxlint-plugin-t3code): 5 passed.
• Negative controls, each a temporary edit to the rule: dropping the identifier check fails the direct case; dropping the member-expression check fails both global-object cases; dropping the computed-property check fails the globalThis["ResizeObserver"] case; reporting every new fails the MutationObserver case.
• vp run check:changed 1d626d02d95f9a2343553f6498037ee82290d304: format, lint, knip, typecheck and the focused test pass.

Not checked:

• new self.ResizeObserver(...), which takes the same path as window.
• The full test suites, which CI runs.

Prior PRs

• fix(web): every resize-driven layout commits in the same frame #17656 by maria-rcks added this rule and observeResize. No earlier PR added tests for it.

Generated with Claude Opus 5.5 in T3 Code Nightly

[macroscopeapp]

The harness already verifies the rule diagnostic; this additionally pins copy text, which the testing guidelines exclude. Could you remove this message assertion and the now-unused assert import?

^{Posted via Macroscope — Test Signal}

[macroscopeapp]

Approvability

Verdict: Approved at 2752b06

Macroscope's review found this PR approvable — The change is confined to ignored paths and adds tests for existing ResizeObserver lint behavior. The outstanding diagnostic-copy assertion comment is a test-maintenance concern, with no evident material product risk.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 3fd2b85
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: b0fa1997-341d-43c1-8e65-20a57db4dc22

Commits

Reviewing files that changed from the base of the PR and between 2752b06 and 4b8552e.

Files selected for processing: 1

• oxlint-plugin-t3code/rules/no-raw-resize-observer.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

Walkthrough

This change adds test cases for t3code/no-raw-resize-observer. The tests cover accepted ResizeObserver type references and feature detection, accepted MutationObserver construction, and reported ResizeObserver construction patterns.

Changes: ResizeObserver rule tests

Layer / File(s)	Summary
Rule test cases oxlint-plugin-t3code/rules/no-raw-resize-observer.test.ts	Adds accepted cases for ResizeObserver types, feature detection, and MutationObserver construction. Invalid cases cover direct, window, and computed globalThis ResizeObserver construction.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Merge Risk: Minimal · up to 4b855

This test-only change is mergeable with no identified blocking risk.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title "test(lint): pin which ResizeObserver constructions no-raw-resize-observer reports" matches the single change in the changeset, which adds a test file for the no-raw-resize-observer rule. It…
Description check		The description follows the template structure. It has Problem, Change, Scope and approval, and Verification sections. The Problem section explains why the test coverage matters. The Change section li…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "test(lint): pin which ResizeObserver constructions no-raw-resize-observer reports" matches the single change in the changeset, which adds a test file for the no-raw-resize-observer rule. It follows the conventional commit format and names the rule and the behavior under test. The title is 81 characters, which is slightly long but still readable.

Full details: Description check

Explanation

The description follows the template structure. It has Problem, Change, Scope and approval, and Verification sections. The Problem section explains why the test coverage matters. The Change section lists the reported and allowed cases. The Scope section explains why no prior approval is needed for test-only coverage. The Verification section gives the focused test command with a result of 5 passed, negative controls, and the changed-files check, and it states what was not checked. The template's optional note about naming the model and harness is handled by the 'Generated with' line. The description does not link a triaged issue, but it explains why none is required for a test-only change, which the template allows for focused work. The description is mostly complete.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts