You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(web): dragging a sidebar thread no longer scrolls the list out from under the pointer - #30346
Dragging a thread in the sidebar was broken whenever the list was taller than the sidebar, which the Working section makes common. On the first move the list jumped several rows, so the drop landed somewhere other than under the pointer.
The cause is the Settled drop hint. It shows for every drag, and since https://git.cafe/pingdotgg/t3code/pulls/26736 it scrolls itself into view whenever its drag transform changes. Starting any drag therefore scrolled the sidebar to the bottom (0 → 343px in the repro) while the pointer stayed put.
Before (Working section on): the list jumps on the first move and rows overlap.
After: the list stays put and rows shift under the pointer.
Dragging down to Settled still brings the hint into view:
A second case made the list jump while the pointer was held still near the bottom. Projected rows count toward the list's scroll range, so the range shrank whenever the target flipped between Active and Settled. The browser clamped scrollTop, rows moved under the pointer, and the target flipped back, looping with auto-scroll. The list now reserves the largest projected overflow (two boundary labels and two hints, 120px) for the whole drag, so the range stays constant.
Before: holding a row at the bottom, the list keeps jumping.
After: the list settles once and Settled stays the target.
Verified in a dev build with agent-browser, with the Working section on and off, including a working thread finishing mid-drag.
…om under the pointer
The Settled drop hint scrolled itself into view on every drag, so a tall
sidebar jumped to the bottom as soon as a drag started. Reveal it only
while Settled is the drop target.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Macroscope's review found this PR approvable — This stabilizes sidebar scrolling during thread dragging by reserving overflow space and limiting automatic placeholder scrolling to the drop target. Its effects are confined to transient UI behavior, with no changes to saved data or thread actions.
You can add or adjust custom eligibility rules. Learn more.
No actionable comments were generated in the recent review.
Walkthrough
During an active thread drag, the sidebar list gains a non-interactive bottom extension. A settled placeholder reveals overflow only when its hint is shown and it is the current drop target.
Changes: Sidebar drag scroll
Layer / File(s)
Summary
Adjust sidebar scroll behavior during drag apps/web/src/components/Sidebar.tsx, apps/web/src/components/sidebar/SidebarListMarkers.tsx
During an active drag, the list gains a non-interactive bottom extension. revealOverflow also requires isDropTarget when the marker is settled-placeholder and the hint is shown.
pingdotgg/t3code#27669: The issue concerns unexpected sidebar scrolling during a thread drag. This change adjusts the drag-time scroll range and drop-hint overflow condition.
pingdotgg/t3code#27586: The issue concerns thread movement during drag initiation or reordering. This change adjusts the sidebar list’s scroll range during a drag.
Suggested reviewers:yash-singh1, maria-rcks
Merge Risk: Minimal · up to d65ef
Sidebar dragging should be more stable. A narrow wheel-scroll case may still cause a small shift, but no merge-blocking risk is established.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title clearly and concisely describes the primary fix: preventing sidebar thread dragging from scrolling the list away from the pointer.
Description check
The description clearly documents the problem, root cause, implemented changes, screenshots, and focused verification. It does not explicitly include the Scope and approval section or explain an appro…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description clearly documents the problem, root cause, implemented changes, screenshots, and focused verification. It does not explicitly include the Scope and approval section or explain an approval exemption, but it is otherwise mostly complete and directly related to the fix.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Reviewing files that changed from the base of the PR and between e4df6b9 and d65efb3.
Files selected for processing: 1
apps/web/src/components/Sidebar.tsx
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
…makes the list jump
Projected drag rows count toward the list's scroll range, so the range
shrank whenever the drop target changed. The browser clamped scrollTop,
rows moved under the still pointer, and the target flipped back in a
loop with auto-scroll. Reserve the largest projected overflow for the
whole drag so the range stays constant.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…om under the pointer (pingdotgg#30346)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 37481f0)
Upstream-PR: 30346
Early-Import: the sidebar drop hint fix scrolls the list to the bottom whenever a thread drag starts
incognitojam
pushed a commit
to incognitojam/styal
that referenced
this pull request
Nov 6, 2026
…om under the pointer (pingdotgg#30346)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 37481f0)
Upstream-PR: 30346
Early-Import: the sidebar drop hint fix scrolls the list to the bottom whenever a thread drag starts
#30346 already limits the settled hint's scrollIntoView to drags that
target Settled, so the on-screen guard and its tests are redundant and
the tests fail against current main. Keep the autoscroll tuning, which
still fixes the bottom-edge runaway.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:XS0-9 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dragging a thread in the sidebar was broken whenever the list was taller than the sidebar, which the Working section makes common. On the first move the list jumped several rows, so the drop landed somewhere other than under the pointer.
The cause is the Settled drop hint. It shows for every drag, and since https://git.cafe/pingdotgg/t3code/pulls/26736 it scrolls itself into view whenever its drag transform changes. Starting any drag therefore scrolled the sidebar to the bottom (0 → 343px in the repro) while the pointer stayed put.
The hint now scrolls into view only while Settled is the drop target, which is what https://git.cafe/pingdotgg/t3code/pulls/26736 was for.
Before (Working section on): the list jumps on the first move and rows overlap.
After: the list stays put and rows shift under the pointer.
Dragging down to Settled still brings the hint into view:
A second case made the list jump while the pointer was held still near the bottom. Projected rows count toward the list's scroll range, so the range shrank whenever the target flipped between Active and Settled. The browser clamped
scrollTop, rows moved under the pointer, and the target flipped back, looping with auto-scroll. The list now reserves the largest projected overflow (two boundary labels and two hints, 120px) for the whole drag, so the range stays constant.Before: holding a row at the bottom, the list keeps jumping.
After: the list settles once and Settled stays the target.
Verified in a dev build with agent-browser, with the Working section on and off, including a working thread finishing mid-drag.
Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code