[voltcrash]

Problem

The Worked for anchoring test can fail when its 600px fixture extends below the browser viewport. Playwright scrolls the page to reach the heading before clicking, so the test mistakes that movement for a disclosure anchoring regression. Refs #30398.

Change

Cap this fixture at the browser viewport height, retaining the 600px height on larger viewports. The real Playwright click, readiness wait, and all anchoring assertions are unchanged.

Scope and approval

This qualifies as a very small, focused fix for an obvious test fixture bug under CONTRIBUTING.md. It changes only this browser test. #30404 fixed initial click readiness; #30365 separately addresses product scroll behavior.

Verification

On Linux with Playwright Chromium, the focused test at 900×480 failed on clean main (647bd148b3fb): expected 457 to be close to 473. The same command passes with this patch (1 passed, 39 skipped):

vp test run apps/web/src/components/chat/MessagesTimeline.browser.test.tsx -t 'keeps the worked-for heading' --browser.viewport.width=900 --browser.viewport.height=480

vp run check:changed --concurrency 1 passed: format, lint, both knip passes, typechecks for both affected packages, and all 40 timeline browser tests. No product UI changed, so no screenshot evidence is needed.

Reviewed with review-loop: 1 round with Claude Opus 5.5. Reviewer verdict: approved. No required findings; two optional suggestions were declined to keep the fix focused.

Created with GPT-6.1 Sol in the Codex harness (T3 Code).

[macroscopeapp]

Approvability

Verdict: Approved at 4bfe52a

Macroscope's review found this PR approvable — The change is confined to ignored paths and described as keeping a browser-test fixture within the viewport. No product-default change or other material exposure is indicated.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 567a105
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: c6074bc3-b64f-4a77-b7aa-195f503d5a04

Commits

Reviewing files that changed from the base of the PR and between 4bfe52a and 71940b3.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The browser test fixture now caps the worked-for heading container at the viewport height instead of using a fixed 600px height. A comment records that this keeps the heading visible before Playwright clicks it.

Changes: Worked-for heading test

Layer / File(s)	Summary
Viewport-aware fixture sizing apps/web/src/components/chat/MessagesTimeline.browser.test.tsx	The test container height changes to min(600px, 100vh). A comment notes that this keeps the heading visible before Playwright clicks it.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related issues

• pingdotgg/t3code#30398 — Reports a viewport-dependent failure in the same browser test; this change caps the fixture height at the viewport height.

Possibly related PRs

• pingdotgg/t3code#29661 — Updates the same test by waiting for the heading to become visible before measuring it.
• pingdotgg/t3code#30404 — Updates readiness handling before interacting with the same test.
• pingdotgg/t3code#30365 — Addresses Playwright's pre-click native scroll in the same regression test.

Suggested reviewers: yash-singh1, macroscopeapp

Merge Risk: Minimal · previous review 4bfe5

This test-only change is suitable to merge with normal checks.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly and concisely describes the test-only change to keep the worked-for heading within the viewport. It uses an appropriate conventional commit format.
Description check		The description completes all required sections. It explains the problem, the fixture-height change, scope and approval rationale, focused verification results, broader check results, and why screensh…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description completes all required sections. It explains the problem, the fixture-height change, scope and approval rationale, focused verification results, broader check results, and why screenshots are not applicable.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 647bd14
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 8ebe7ec8-3829-47ce-ae5a-3acc0cf228ef

Commits

Reviewing files that changed from the base of the PR and between 647bd14 and 4bfe52a.

Files selected for processing: 1

• apps/web/src/components/chat/MessagesTimeline.browser.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.