[TonybynMp4]

Problem

GitLab comments from bots are never hidden by the "Bot comments" filter. The adapter reads notes over REST, and REST note authors carry no bot field, so isBot is never set. Closes #30382.

Change

The adapter already sends one GraphQL query per activity read, for reactions (AWARD_EMOJI_GRAPHQL_QUERY), and it walks every note. Its note nodes now also ask for author { username bot }, so this costs no extra request. The decoder collects the bot usernames and the provider sets isBot on matching comment and thread comment authors. That mirrors how the GitHub provider marks bots by login.

The flag only comes from GitLab's own bot field, which covers project and group access tokens, service accounts and GitLab's built-in bots. No username guessing.

Scope and approval

Small fix for an obvious gap: the filter exists on every host, and the GitLab adapter never fed it. Tracked in #30382.

Verification

• New tests fail on main and pass here: the decoder collects bot authors from the GraphQL page, and the provider flags bot authors in the conversation and in review threads.
• vp run check:changed: format, lint, knip, typecheck (11 packages) and tests (136) pass.
• Manual, web dev build against gitlab-org/gitlab!267288, "Bot comments" unchecked:

Before	After
"Comments (5)", all shown	"3 hidden", only the two human comments

Mobile reads the same isBot flag (pullRequestActivityFilter.ts) and needs no change. Not checked on a device.

Fixed by Claude Opus 5.5 in Claude Code, running inside T3 Code.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at a694427

Macroscope's review found this PR approvable — GitLab comment and discussion authors now receive bot flags from GitLab’s metadata, allowing existing bot filters to work consistently. The change is confined to read-side activity classification and leaves filter defaults unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

GitLab award-emoji data now includes bot author logins. The GitLab pull request provider uses those logins to mark matching conversation and review-thread comment authors as bots.

Changes: GitLab bot comment identification

Layer / File(s)	Summary
Collect bot author logins packages/source-control-gitlab/src/server/gitLabMergeRequestJson.ts, packages/source-control-gitlab/src/server/gitLabMergeRequestJson.test.ts	The award-emoji query requests note author usernames and bot flags. The decoder collects bot usernames and returns them with the page data. Tests cover bot author collection.
Mark matching activity authors packages/source-control-gitlab/src/server/GitLabPullRequestCli.ts, packages/source-control-gitlab/src/server/GitLabPullRequestProvider.ts, packages/source-control-gitlab/src/server/GitLabPullRequestProvider.test.ts	The CLI accumulates bot logins across pages. The provider marks matching conversation and thread comment authors with isBot: true. Tests check bot and human authors.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Possibly related PRs

• pingdotgg/t3code#28841: Uses host bot flags to filter conversation and timeline activity; this change supplies GitLab bot flags.
• pingdotgg/t3code#20873: Uses host bot flags for bot-noise filtering; this change provides the corresponding GitLab metadata.
• pingdotgg/t3code#25829: Filters bot-authored review activity based on bot classification, which this change supplies for GitLab comments.

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · up to b41e8

Bot filtering improves, although some replies beyond the note limit may remain visible. This existing limitation does not block merging.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title is concise, uses the conventional commit format, and clearly describes the main GitLab change: marking bot authors as bots.
Description check		The description includes complete Problem, Change, Scope and approval, and Verification sections. It explains the cause, implementation, testing, manual validation, and the unverified mobile-device ch…
Linked Issues check		Issue #30382 requires GitLab bot comments to receive isBot so the bot-comment filter can hide them. The GraphQL note query now requests author { username bot }. The decoder collects usernames wher…
Out of Scope Changes check		The changed files support issue #30382. They add bot-author data to the existing GraphQL response, pass bot logins through the activity result, apply isBot to comment authors, and test the behavior.…

Full details: Description check

Explanation

The description includes complete Problem, Change, Scope and approval, and Verification sections. It explains the cause, implementation, testing, manual validation, and the unverified mobile-device check.

Full details: Linked Issues check

Explanation

Issue #30382 requires GitLab bot comments to receive isBot so the bot-comment filter can hide them. The GraphQL note query now requests author { username bot }. The decoder collects usernames where author.bot === true. The provider matches those logins case-insensitively and sets isBot on top-level and review-thread comment authors. Tests cover bot collection, bot flags, and an unflagged human author. The implementation uses the existing activity-read request and adds no extra request.

Full details: Out of Scope Changes check

Explanation

The changed files support issue #30382. They add bot-author data to the existing GraphQL response, pass bot logins through the activity result, apply isBot to comment authors, and test the behavior. No unrelated change appears in the reported diff.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 663cd08
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 5b330613-b496-4859-8fdc-955b6a66e9cd

Commits

Reviewing files that changed from the base of the PR and between 663cd08 and b41e806.

Files selected for processing: 5

• packages/source-control-gitlab/src/server/GitLabPullRequestCli.ts
• packages/source-control-gitlab/src/server/GitLabPullRequestProvider.test.ts
• packages/source-control-gitlab/src/server/GitLabPullRequestProvider.ts
• packages/source-control-gitlab/src/server/gitLabMergeRequestJson.test.ts
• packages/source-control-gitlab/src/server/gitLabMergeRequestJson.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

[coderabbitai]

Additional comments: 1

packages/source-control-gitlab/src/server/GitLabPullRequestProvider.ts-340-340: 1

340-340: Minor · Functional Correctness · Quick win

Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Match bot logins without case sensitivity.

If GraphQL supplies BuildBot and a REST comment supplies buildbot, Set.has leaves the bot comment unflagged. The “Bot comments” filter then shows that comment. Normalize both logins before matching, and cover the mismatch in the existing activity test. GitLab supports case-insensitive username lookup. (docs.gitlab.com)

Review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: a104909
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 6ca48b0a-42d8-44a0-815a-e8e4252e5591

Commits

Reviewing files that changed from the base of the PR and between a104909 and a694427.

Files selected for processing: 5

• packages/source-control-gitlab/src/server/GitLabPullRequestCli.ts
• packages/source-control-gitlab/src/server/GitLabPullRequestProvider.test.ts
• packages/source-control-gitlab/src/server/GitLabPullRequestProvider.ts
• packages/source-control-gitlab/src/server/gitLabMergeRequestJson.test.ts
• packages/source-control-gitlab/src/server/gitLabMergeRequestJson.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

merged current main without rebasing and fixed the review finding: bot-author matching now normalizes both graphql and rest usernames. the existing activity test covers differing casing in conversation and thread comments.

blacksmith verification: the regression failed before the fix, then vp run check:changed passed formatting, lint, knip, typechecks for 11 affected packages, and 136 tests across 6 files. live gitlab api verification remains unverified. the original web failure was a message-timeline click timeout; no unrelated timeline code was changed.