[ElliotDrel]

Fixes #30950.

Windows server tests searched JSON-serialized payloads for unescaped paths, assumed POSIX repository-root settings lookup, and used a literal POSIX Codex path suffix. This test-only fix matches JSON encoding, checks platform-specific settings selection with direct root precedence coverage, and builds the suffix with NodePath.join. Production quoting and runtime behavior are unchanged.

Scope and approval

This is a focused correction of existing Windows test expectations under the small, obvious-bug contribution exception. It changes three test files, adds no skips or production behavior, and leaves maintainer acceptance pending.

Verification on Windows:

• Three affected files: 327 passed, 13 existing skips, 1 timeout in the unchanged office/EPUB archive-extraction neighbor. Isolated attachment-file rerun: 29 passed and the same archive test timed out.
• All 17 reported assertion failures passed; final settings case rerun passed.
• Targeted lint, formatting, server typecheck, and server bundle build passed.

Current-head hosted CI: all eight required checks pass at 6ec72888b69c5b8a9916517b59e74d8d187bc807; CodeRabbit reports no actionable findings.

Implemented by gpt-6.1-sol (medium reasoning) through the Codex harness.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-04T16:41:15.162106Z	6ec7288	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[macroscopeapp]

Approvability

Verdict: Approved at 6ec7288

Macroscope's review found this PR approvable — This change adjusts Windows path and settings assertions in server tests. Its scope is confined to ignored test files, with no production behavior, product-default, or diagnostic-suppression changes.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

Server test expectations now account for JSON-escaped attachment paths, platform-specific Claude settings lookup, and platform-specific path separators. The changes update tests only.

Changes: Windows test expectations

Layer / File(s)	Summary
JSON-escaped attachment paths apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts, apps/server/src/provider/userInputAttachments.test.ts	Attachment-path assertions now expect JSON-escaped paths, including paths with quoted filenames and the __proto__ question key.
Platform-specific settings and paths apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts, apps/server/src/provider/Drivers/CodexDriver.test.ts	Claude settings assertions now account for Windows working-directory lookup and POSIX repository-root lookup. The Codex shadow-home path expectation now uses NodePath.join.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: maria-rcks

Merge Risk: Minimal · up to 6ec72

The PR only corrects platform-specific test expectations and introduces no established current-head production or test risk.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title "test(server): correct Windows path and settings assertions" matches the change. The PR updates Windows server tests so they compare JSON-escaped paths, checks platform-specific settings sel…
Linked Issues check		Issue #30950 has one directly linked target and no active parent context. Its coding requirements are three test-only corrections. (1) JSON-escaped paths: ClaudeAdapterV2.test.ts now compares JSON.str…
Out of Scope Changes check		The whole-PR diff from merge base 9e85538 to head 6ec7288 touches only three test files: ClaudeAdapterV2.test.ts, CodexDriver.test.ts, and userInputAttachments.test.ts. All edits are assertion or expe…
Description check		The description is mostly complete. It explains the Windows test problem, the corrective changes, scope exception, verification results, CI status, and agent attribution. The content is provided witho…

Full details: Title check

Explanation

The title "test(server): correct Windows path and settings assertions" matches the change. The PR updates Windows server tests so they compare JSON-escaped paths, checks platform-specific settings selection, and builds the Codex path suffix with NodePath.join. It is a test-only change with no production code changes. The title follows conventional commit form and is specific enough for a teammate to understand the main change.

Full details: Linked Issues check

Explanation

Issue #30950 has one directly linked target and no active parent context. Its coding requirements are three test-only corrections. (1) JSON-escaped paths: ClaudeAdapterV2.test.ts now compares JSON.stringify(path).slice(1, -1) inside JSON.stringify(payload) at lines 2038, 2087, 2106, 2168, and 2381. This is the correct depth for a path embedded in a JSON string. userInputAttachments.test.ts now expects JSON.stringify(path) and JSON.stringify(path + ".txt") at lines 296, 357, 1149, and 1160. This matches the production JSON quoting. Content assertions are kept. (2) Claude settings lookup: the tool-search test now uses HostProcess.Platform. On win32 the worktree case resolves from cwd and yields "true" or undefined as expected. On POSIX the previous expectations for worktree and packages/app are kept, and a repo-root case is added. Local settings still beat user settings. (3) Codex suffix: CodexDriver.test.ts builds the expected shadow path with NodePath.join("providers", "codex", instanceId, "shadow"). No skip or weakened assertion is introduced. Limits: the diff confirms the edits but not the imports of HostProcess and NodePath. The Windows pass counts and the typecheck result are author-reported, not independently rerun.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff from merge base 9e85538 to head 6ec7288 touches only three test files: ClaudeAdapterV2.test.ts, CodexDriver.test.ts, and userInputAttachments.test.ts. All edits are assertion or expectation changes that map to the three objectives in #30950. No production source file changed. The ACP detached .cmd hang (#29088, PR #30544) is not touched. No unrelated refactoring, new skips, or removed assertions appear in the reviewed hunks. The change to the userInputAttachments proto and quoted-filename expectations sits on lines that already assert the same attachment path, so it stays within the JSON-escaping objective.

Full details: Description check

Explanation

The description is mostly complete. It explains the Windows test problem, the corrective changes, scope exception, verification results, CI status, and agent attribution. The content is provided without the template's explicit Problem and Change headings, but those details are clear from the opening paragraphs.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 9e85538
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 2bbde2bc-3af0-4e16-930c-6a60359b5960

Commits

Reviewing files that changed from the base of the PR and between 9e85538 and 6ec7288.

Files selected for processing: 3

• apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts
• apps/server/src/provider/Drivers/CodexDriver.test.ts
• apps/server/src/provider/userInputAttachments.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.